[CCIP-2937] Fixes Conflicts and Run Issues with CCIP E2E Tests Merge #14070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalverra
requested review from
Bwest981,
anirudhwarrier,
davidcauchi,
AnieeG and
b-gopalswami
asoliman92
reviewed
Aug 8, 2024
asoliman92
force-pushed
the
ccip/merge-e2e-tests-and-ci-fix
branch
from
2d4ce1c to
f7850db
Compare
asoliman92
force-pushed
the
ccip/merge-e2e-tests-and-ci-fix
branch
from
f7850db to
330b955
Compare
|
AnieeG
reviewed
Aug 12, 2024
| @@ -1,390 +0,0 @@ | |||
| name: CCIP Offchain Upgrade Compatibility Tests | |||
There was a problem hiding this comment.
For now it's messy. If we fix it to run okay now, it risks testing the wrong version upgrade path and giving us false negatives. If we leave it broken, it risks people disregarding it as a flake in the future. The plan is to revive it [TT-1448] when we've ironed out the new release process for CCIP in the main repo.
AnieeG
approved these changes
Aug 12, 2024
kalverra
merged commit 92111d0
into
ccip/merge-e2e-tests-and-ci
153 of 154 checks passed
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 14, 2024
* [CCIP-2937] Copy ccip-tests and CI to Core (#14069) * gitignore * Fix gitignore * Adds CCIP Tests Dir * Adds CCIP CI * [CCIP-2937] Fixes Conflicts and Run Issues with CCIP E2E Tests Merge (#14070) * Fixes CI conflicts * Fixes config path * Separate CCIP smoke tests * Change repo for compatibility tests * Remove references to separate CCIP repo * Callout needed updates * Remove CCIP Upgrade Test --------- Co-authored-by: asoliman <[email protected]> * Fixes * Go mod * Ports over fixes for CCIP network tests --------- Co-authored-by: asoliman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges in fixes for the initial issues found with plain copy-paste of CCIP code into core. There is much more to do, which is tracked by TT-1441. And especially updates to CI needed, tracked by TT-1448.