Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CCIP-2944] Merge CCIP E2E Tests and CI into Core Repo #14102

Merged
merged 9 commits into from
Aug 14, 2024

Conversation

kalverra
Copy link
Collaborator

This PR merges CCIP E2E tests and CI flows into the core repo. Some CI flows were removed as they have to do with releases on the new repo which haven't been solidified yet. There's more work to be done that is being tracked in TT-1441, but this should give us bare functionality for CCIP E2E tests in core.

kalverra and others added 2 commits August 7, 2024 16:56
* gitignore

* Fix gitignore

* Adds CCIP Tests Dir

* Adds CCIP CI
…14070)

* Fixes CI conflicts

* Fixes config path

* Separate CCIP smoke tests

* Change repo for compatibility tests

* Remove references to separate CCIP repo

* Callout needed updates

* Remove CCIP Upgrade Test

---------

Co-authored-by: asoliman <[email protected]>
@kalverra kalverra requested a review from AnieeG August 12, 2024 21:34
@kalverra kalverra requested review from a team as code owners August 12, 2024 21:34
@kalverra kalverra requested a review from asoliman92 August 12, 2024 21:34
integration-tests/go.mod Outdated Show resolved Hide resolved
.github/workflows/integration-tests.yml Outdated Show resolved Hide resolved
workflow_run:
workflows: [ CCIP Load Test ]
types: [ completed ]
branches: [ ccip-develop ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs update

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, updated it elsewhere too.

hostname: ${{ secrets.GRAFANA_INTERNAL_HOST }}
this-job-name: ETH Smoke Tests CCIP
matrix-aggregator-status: ${{ needs.eth-smoke-tests-matrix-ccip.result }}
continue-on-error: true
Copy link
Contributor

@Tofel Tofel Aug 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason for not making it part of eth-smoke-tests job? Is it so that we could skip them and exclude from required check?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CCIP tests shouldn't be run on every single PR. We can gate them to run only on changes in the ccip directories. For now I'm leaving them running on each PR to stabilize this transition, but will separate them more clearly soon.

Copy link
Contributor

@AnieeG AnieeG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This overall looks good. It needs some subsequent effort to align the tests and workflows with rest of the products'

else
echo "run_command=./smoke/${{ matrix.product.name }}_test.go" >> "$GITHUB_OUTPUT"
echo "run_command=./${dir}/${{ matrix.product.name }}_test.go" >> "$GITHUB_OUTPUT"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, efforts there are tracked in TT-1441

return func(c *chainlink.Config) {
c.EVM = evmConfigs
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good callout, adding to TT-1441

uses: smartcontractkit/chainlink-github-actions/chainlink-testing-framework/show-test-summary@75a9005952a9e905649cfb5a6971fd9429436acd # v2.3.25

eth-smoke-tests-matrix-ccip:
if: ${{ !contains(join(github.event.pull_request.labels.*.name, ' '), 'skip-smoke-tests') }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's what we will use so that passing of this job is not required?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. We can require the CCIP tests separately.

Tofel
Tofel previously approved these changes Aug 13, 2024
@cl-sonarqube-production
Copy link

@kalverra kalverra added this pull request to the merge queue Aug 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 14, 2024
@kalverra kalverra added this pull request to the merge queue Aug 14, 2024
Merged via the queue into develop with commit 8d332fd Aug 14, 2024
139 checks passed
@kalverra kalverra deleted the ccip/merge-e2e-tests-and-ci branch August 14, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants