Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TT-1435] slither diff chatgpt test #14111

Closed
wants to merge 7 commits into from
Closed

[TT-1435] slither diff chatgpt test #14111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
51a202b
use exit instead of return
Tofel Aug 14, 2024
6151dbb
test exit instead of return
Tofel Aug 14, 2024
16b2c80
revert test script change
Tofel Aug 14, 2024
19b3be8
remove test change
Tofel Aug 14, 2024
279fdda
try with another contract
Tofel Aug 14, 2024
67f9879
remove from ccip add to functions
Tofel Aug 14, 2024
1e778e4
revert AggregateRateLimiter.sol change
Tofel Aug 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions contracts/scripts/ci/find_slither_report_diff.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ openai_result=$(echo '{
# throw error openai_result when is not 200
if [ "$openai_result" != '200' ]; then
echo "::error::OpenAI API call failed with status $openai_result: $(cat prompt_response.json)"
return 1
exit 1
fi

# replace lines starting with ' -' (1space) with ' -' (2spaces)
Expand Down Expand Up @@ -80,7 +80,7 @@ if [[ -n "$validation_prompt_path" ]]; then
# throw error openai_result when is not 200
if [ "$validation_result" != '200' ]; then
echo "::error::OpenAI API call failed with status $validation_result: $(cat prompt_validation_response.json)"
return 1
exit 1
fi

# replace lines starting with ' -' (1space) with ' -' (2spaces)
Expand Down
12 changes: 12 additions & 0 deletions contracts/src/v0.8/functions/v1_3_0/FunctionsBilling.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,18 @@ abstract contract FunctionsBilling is Routable, IFunctionsBilling {
return s_config;
}

fallback() external {
// copied directly from OZ's Proxy contract
assembly {
// Copy msg.data. We take full control of memory in this inline assembly
// block because it will not return to Solidity code. We overwrite the
// Solidity scratch pad at memory position 0.
calldatacopy(0, 0, calldatasize())

return(0, returndatasize())
}
}

/// @notice Sets the Chainlink Coordinator's billing configuration
/// @param config - See the contents of the FunctionsBillingConfig struct in IFunctionsBilling.sol for more information
function updateConfig(FunctionsBillingConfig memory config) public {
Expand Down
Loading