Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial implementation of Configurator for LLO #14249

Merged
merged 4 commits into from
Sep 3, 2024
Merged

Initial implementation of Configurator for LLO #14249

merged 4 commits into from
Sep 3, 2024

Conversation

samsondav
Copy link
Collaborator

Requires Dependencies

Resolves Dependencies

@samsondav samsondav requested a review from Fletch153 August 27, 2024 16:43
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 27, 2024 •
edited
Loading

Static analysis results are available

Hey @samsondav, you can view Slither reports in the job summary here or download them as artifact here.

Please check them before merging and make sure you have addressed all issues.

@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@samsondav samsondav force-pushed the MERC-6185-configuration-contract-and-tracker-can-we-just-re-use-standard-ocr-2-aggregator branch 2 times, most recently from 2b83724 to 7f4cf14 Compare August 27, 2024 17:38
@samsondav samsondav changed the title Initial implementation of SourceVerifier Initial implementation of Configurator for LLO Aug 27, 2024
@samsondav samsondav force-pushed the MERC-6185-configuration-contract-and-tracker-can-we-just-re-use-standard-ocr-2-aggregator branch 4 times, most recently from ac6a263 to d2cef17 Compare August 29, 2024 18:28
@samsondav samsondav marked this pull request as ready for review August 29, 2024 20:16
@samsondav samsondav requested a review from a team as a code owner August 29, 2024 20:16
@samsondav samsondav requested review from cedric-cordenier and removed request for a team August 29, 2024 20:16
@samsondav samsondav force-pushed the MERC-6185-configuration-contract-and-tracker-can-we-just-re-use-standard-ocr-2-aggregator branch from db5f702 to 6c39ed8 Compare August 29, 2024 20:31
@samsondav samsondav force-pushed the MERC-6185-configuration-contract-and-tracker-can-we-just-re-use-standard-ocr-2-aggregator branch 2 times, most recently from 17daa3d to 5defc3a Compare August 30, 2024 14:26
@samsondav samsondav requested a review from Fletch153 August 30, 2024 15:34
Fletch153
Fletch153 previously approved these changes Aug 30, 2024
View reviewed changes
@samsondav samsondav force-pushed the MERC-6185-configuration-contract-and-tracker-can-we-just-re-use-standard-ocr-2-aggregator branch from 678a10c to 6d4a9ab Compare September 3, 2024 13:12
@samsondav samsondav requested a review from Fletch153 September 3, 2024 13:13
Fletch153
Fletch153 previously approved these changes Sep 3, 2024
View reviewed changes
Fletch153
Fletch153 previously approved these changes Sep 3, 2024
View reviewed changes
@samsondav samsondav enabled auto-merge September 3, 2024 13:27
msuchacz-cll
msuchacz-cll previously approved these changes Sep 3, 2024
View reviewed changes
@samsondav samsondav added this pull request to the merge queue Sep 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 3, 2024
@samsondav samsondav added this pull request to the merge queue Sep 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 3, 2024
@Fletch153 Fletch153 dismissed stale reviews from msuchacz-cll and themself via 4f1b11a September 3, 2024 14:41
@samsondav samsondav enabled auto-merge September 3, 2024 14:41
@samsondav
Merge branch 'develop' into MERC-6185-configuration-contract-and-trac…
91c2552 
…ker-can-we-just-re-use-standard-ocr-2-aggregator
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
2 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
82.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@samsondav samsondav added this pull request to the merge queue Sep 3, 2024
Merged via the queue into develop with commit e8c2453 Sep 3, 2024
154 of 155 checks passed
@samsondav samsondav deleted the MERC-6185-configuration-contract-and-tracker-can-we-just-re-use-standard-ocr-2-aggregator branch September 3, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msuchacz-cll msuchacz-cll msuchacz-cll approved these changes

@Fletch153 Fletch153 Fletch153 approved these changes

@brunotm brunotm brunotm approved these changes

@cedric-cordenier cedric-cordenier Awaiting requested review from cedric-cordenier cedric-cordenier is a code owner automatically assigned from smartcontractkit/foundations

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samsondav @brunotm @Fletch153 @msuchacz-cll