[KS-430] Provide an OracleFactory to StandardCapabilities #14305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-api # Conflicts: # core/scripts/go.mod # core/scripts/go.sum # go.mod # go.sum # integration-tests/go.mod # integration-tests/go.sum # integration-tests/load/go.mod # integration-tests/load/go.sum
DeividasK
changed the title
…nject-the-libocr-oracle-api # Conflicts: # integration-tests/go.mod # integration-tests/load/go.mod
core/services/job/models.go
Outdated
| UpdatedAt time.Time `toml:"-"` | ||
| Command string `toml:"command"` | ||
| Config string `toml:"config"` | ||
| OracleFactory JSONConfig `toml:"oracleFactory"` |
There was a problem hiding this comment.
@DeividasK OracleFactoryConfig?
There was a problem hiding this comment.
Can we put a comment here to document where we define what's expected in OracleConfig?
| @@ -67,8 +78,38 @@ func (d *Delegate) ServicesForSpec(ctx context.Context, spec job.Job) ([]job.Ser | |||
| return nil, fmt.Errorf("failed to create relayer set: %w", err) | |||
| } | |||
|
|
|||
| keyBundles, err := d.ocrKs.GetAll() | |||
There was a problem hiding this comment.
I'm not 100% certain this will work, but we can try it
…nject-the-libocr-oracle-api # Conflicts: # core/scripts/go.mod # core/scripts/go.sum # core/services/chainlink/application.go # core/services/standardcapabilities/delegate.go # core/services/workflows/engine.go # go.mod # go.sum # integration-tests/go.mod # integration-tests/go.sum # integration-tests/load/go.mod # integration-tests/load/go.sum
…nject-the-libocr-oracle-api # Conflicts: # core/scripts/go.mod # core/scripts/go.sum # core/services/workflows/engine.go # go.mod # go.sum # integration-tests/go.mod # integration-tests/go.sum # integration-tests/load/go.mod # integration-tests/load/go.sum
…nject-the-libocr-oracle-api
cedric-cordenier
previously approved these changes
Oct 9, 2024
DeividasK
commented
Oct 9, 2024
jmank88
reviewed
Oct 9, 2024
jmank88
reviewed
Oct 9, 2024
jmank88
reviewed
Oct 9, 2024
jmank88
reviewed
Oct 9, 2024
…nject-the-libocr-oracle-api # Conflicts: # core/scripts/go.sum # go.mod # go.sum # integration-tests/go.mod # integration-tests/go.sum # integration-tests/load/go.sum
jmank88
approved these changes
Oct 9, 2024
|
cedric-cordenier
approved these changes
Oct 9, 2024
nolag
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on