Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TT-1600] corrected handling of tags #14312

Merged
merged 6 commits into from
Sep 4, 2024
Merged

Conversation

Tofel
Copy link
Contributor

@Tofel Tofel commented Sep 3, 2024

Background:
Tags were incorrectly handled, because they do not map 1:1 to Docker images. From the latter ones we strip v prefix, so that v2.15.0 becomes 2.15.0. This wasn't handled properly as I assumed that both are identical.

Additionally, Slack handle that should be informed was changed to one that disturbs less people.

Tests:

  • Execute pipeline with tag v2.14.0 for the first time -> image is build, test is run execution
  • Execute pipeline with tag v2.14.0 for the second time -> image building is skipped, test is run execution
  • Execute pipeline with HEAD commit SHA -> image is built, test is run execution
  • Execute pipeline with a broken test -> new handle is used in Slack notification execution

@Tofel Tofel force-pushed the tt_1600_tag_in_compat_pipeline branch from 0bbc572 to 2d37920 Compare September 4, 2024 07:43
@Tofel Tofel marked this pull request as ready for review September 4, 2024 08:50
@Tofel Tofel requested review from a team as code owners September 4, 2024 08:50
@Tofel Tofel requested review from jmank88 and removed request for a team September 4, 2024 08:50
lukaszcl
lukaszcl previously approved these changes Sep 4, 2024
Copy link
Collaborator

@lukaszcl lukaszcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@momentmaker
Copy link
Contributor

there is a -o file committed by accident

@Tofel Tofel enabled auto-merge September 4, 2024 14:52
@Tofel Tofel added this pull request to the merge queue Sep 4, 2024
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Merged via the queue into develop with commit 3ba567d Sep 4, 2024
76 checks passed
@Tofel Tofel deleted the tt_1600_tag_in_compat_pipeline branch September 4, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants