-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TT-1600] corrected handling of tags #14312
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… if compatibility pipeline is triggered by tag
0bbc572
to
2d37920
Compare
lukaszcl
previously approved these changes
Sep 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
there is a |
2d37920
to
7867c48
Compare
momentmaker
approved these changes
Sep 4, 2024
lukaszcl
approved these changes
Sep 4, 2024
kalverra
approved these changes
Sep 4, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background:
Tags were incorrectly handled, because they do not map
1:1
to Docker images. From the latter ones we stripv
prefix, so thatv2.15.0
becomes2.15.0
. This wasn't handled properly as I assumed that both are identical.Additionally, Slack handle that should be informed was changed to one that disturbs less people.
Tests:
v2.14.0
for the first time -> image is build, test is run executionv2.14.0
for the second time -> image building is skipped, test is run execution