-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CCIP-3087] Set nonce manager config for chain reader. Tests. #14318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winder
requested review from
RensR,
matYang,
RayXpub,
elatoskinas and
a team
as code owners
September 3, 2024 14:57
I see you updated files related to |
makramkd
reviewed
Sep 3, 2024
winder
force-pushed
the
will/nonce-manager-config
branch
from
September 3, 2024 21:31
614445b
to
4a842ba
Compare
winder
force-pushed
the
will/nonce-manager-config
branch
2 times, most recently
from
September 3, 2024 23:17
5fa4dad
to
80113d0
Compare
Update chainlink-ccip. Add changeset file.
winder
force-pushed
the
will/nonce-manager-config
branch
from
September 4, 2024 13:48
ac85ef7
to
6c7065c
Compare
makramkd
previously approved these changes
Sep 4, 2024
asoliman92
reviewed
Sep 4, 2024
winder
commented
Sep 4, 2024
core/capabilities/ccip/ccip_integration_tests/ccipreader/ccipreader_test.go
Outdated
Show resolved
Hide resolved
asoliman92
approved these changes
Sep 4, 2024
Quality Gate passedIssues Measures |
makramkd
approved these changes
Sep 4, 2024
This was referenced Sep 5, 2024
RensR
pushed a commit
that referenced
this pull request
Oct 1, 2024
* Set nonce manager config for chain reader. Tests. Update chainlink-ccip. Add changeset file. * Update core/capabilities/ccip/ccip_integration_tests/ccipreader/ccipreader_test.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add chainreader configuration for NonceManager contract for usage in CCIP OCR3 Execution plugin.
Add test for CCIPReader Nonces function.
Update PriceRegistry configuration to use method name consts.