Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/services/chainlink: normalize feature config #14324

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented Sep 3, 2024

The new MultiFeedsManagers feature flag came with an extra exceptional method for accessing indirectly via global config. This PR removes FeatureMultiFeedsManagers() and adjusts callers to use the standard pattern.

@jmank88 jmank88 requested review from a team as code owners September 3, 2024 22:09
@jmank88 jmank88 requested review from ilija42, graham-chainlink and a team and removed request for a team September 3, 2024 22:09
@jmank88 jmank88 enabled auto-merge September 3, 2024 22:09
Copy link
Contributor

github-actions bot commented Sep 3, 2024

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

Copy link
Collaborator

@graham-chainlink graham-chainlink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for showing me the right way to inject the feature tag into the service!

@jmank88 jmank88 added this pull request to the merge queue Sep 4, 2024
Merged via the queue into develop with commit f7fec9c Sep 4, 2024
134 of 135 checks passed
@jmank88 jmank88 deleted the normalize-feature-config branch September 4, 2024 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants