Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/services/relay/evm: handle error from chainselectors #14337

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented Sep 4, 2024

Partial backport of #14322

@jmank88 jmank88 requested a review from a team as a code owner September 4, 2024 18:30
@jmank88 jmank88 requested review from samsondav, Bwest981 and chainchad and removed request for a team September 4, 2024 18:30
Copy link
Collaborator

@chainchad chainchad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@momentmaker
Copy link
Contributor

@jmank88
Copy link
Contributor Author

jmank88 commented Sep 4, 2024

it's still failing here no? smartcontractkit/chainlink/actions/runs/10707474078/job/29687530657?pr=14337#step:4:12

Yes, but I don't know what that check is for. Bumping the chain selector dep was never part of this. There just seem to be new releases available since this core release was cut 🤷

@jmank88 jmank88 requested a review from momentmaker September 5, 2024 18:18
@momentmaker momentmaker merged commit 5eac567 into release/2.16.0 Sep 6, 2024
129 of 131 checks passed
@momentmaker momentmaker deleted the chain-selector-fix branch September 6, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants