Productionize llo transmitter #14355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsondav
force-pushed
the
MERC-3659-standalone-llo-transmitter
branch
3 times, most recently
from
eb67ede to
d6eed74
Compare
samsondav
requested review from
cedric-cordenier
and removed request for
a team
samsondav
commented
Sep 9, 2024
| @@ -22,7 +22,7 @@ func TestEVMForwarderPresenter_RenderTable(t *testing.T) { | |||
| t.Parallel() | |||
|
|
|||
| var ( | |||
| id = "1" | |||
| id = "ID:" | |||
There was a problem hiding this comment.
This was needed to fix a flake
samsondav
force-pushed
the
MERC-3659-standalone-llo-transmitter
branch
4 times, most recently
from
423ffd1 to
b824d18
Compare
| if p.RawServerURL == "" { | ||
| merr = errors.Join(merr, errors.New("llo: ServerURL must be specified")) | ||
| if len(p.Servers) == 0 { | ||
| merr = errors.Join(merr, errors.New("llo: At least one Mercury server must be specified")) |
There was a problem hiding this comment.
Should it be "Mercury server"? this transmitter is purely for Data Engine?
There was a problem hiding this comment.
Well, in this case the nomenclature is shifting a bit. I’m still referring to the server as “mercury”, this is specific to transmitting to the server.
The plugin itself does not reference it
samsondav
force-pushed
the
MERC-3659-standalone-llo-transmitter
branch
from
6e1742a to
2d74231
Compare
brunotm
previously approved these changes
Sep 10, 2024
samsondav
force-pushed
the
MERC-3659-standalone-llo-transmitter
branch
from
3052c57 to
f53a551
Compare
samsondav
force-pushed
the
MERC-3659-standalone-llo-transmitter
branch
from
f53a551 to
ce9948c
Compare
msuchacz-cll
previously approved these changes
Sep 10, 2024
akuzni2
previously approved these changes
Sep 10, 2024
akuzni2
reviewed
Sep 10, 2024
brunotm
previously approved these changes
Sep 11, 2024
This mostly copies over similar patterns and structure from the battle-tested mercury transmitter, with a few modifications to generalize it to LLO
samsondav
dismissed stale reviews from akuzni2 and msuchacz-cll
via
65c1eec
samsondav
force-pushed
the
MERC-3659-standalone-llo-transmitter
branch
from
ce9948c to
65c1eec
Compare
brunotm
approved these changes
Sep 11, 2024
|
msuchacz-cll
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Productionize LLO transmitter.
This mostly copies over similar patterns and structure from the battle-tested mercury transmitter, with a few modifications to generalize it to LLO.