support new heads polling over http rpc client #14373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-of-head-subscriptions
…-flag-for-NewHeadsPollInterval add new flag, NewHeadsPollInterval
…op handling logic. To add unit test
huangzhen1997
requested review from
reductionista,
DylanTinianov and
dhaidashenko
huangzhen1997
changed the title
dhaidashenko
requested changes
Sep 19, 2024
dhaidashenko
previously approved these changes
Sep 20, 2024
|
| if r.newHeadsPollInterval > 0 { | ||
| interval := r.newHeadsPollInterval | ||
| timeout := interval | ||
| poller, _ := commonclient.NewPoller[*evmtypes.Head](interval, r.latestBlock, timeout, r.rpcLog) |
There was a problem hiding this comment.
Why copy r.newHeadsPollInterval twice? Not a big deal either way I guess, just wondering why not just:
poller, _ := commonclient.NewPoller[*evmtypes.Head](interval, r.latestBlock, interval, r.rpcLog)
or even:
poller, _ := commonclient.NewPoller[*evmtypes.Head](r.newHeadsPollInterval, r.latestBlock, r.newHeadsPollInterval, r.rpcLog)
?
There was a problem hiding this comment.
It makes the line 499 more readable, so it's not looking like passing the same parameter twice. And it's more configurable if we decided to update the timeout value later. And it's consistent with the SubscribeToFinalizedHeads function
reductionista
approved these changes
Sep 23, 2024
dhaidashenko
approved these changes
Sep 23, 2024
dimriou
deleted the
BCFR-706/rpc-client-polling-implementation-of-head-subscriptions
branch
momentmaker
added a commit
that referenced
this pull request
Sep 24, 2024
…develop * origin/develop: (233 commits) update Smoke Test TestAutomationBasic to load pre-deployed contracts if given (#14537) CCIP-2881 USDC Reader integration tests (#14516) [TT-1624] link PR to solidity review issue (#14521) Fix skipped notification in E2E test workflow (#14538) Add regression testing for pruning bug (#14454) Bump owner dep (#14531) Fix state view (#14532) Deployment tooling (#14533) CCIP 3388 - add offramp generation (#14526) CCIP-3416 paginate token admin registry get all tokens call (#14514) Change Polygon zkEVM to use FeeHistory estimator (#14161) [TT-1747] fix core changeset (#14524) TT-1459 Use CTF actions from .github repo (#14522) [TT-1693] try more universal Solidity scripts (#14436) Remove unused workflow for e2e tests (#14520) BCI-3668 Optimise HeadTracker's memory usage (#14130) BCFR-888 LP support chains that have not reached finality yet (#14366) support new heads polling over http rpc client (#14373) Bump CTF (#14518) TT-1550 Migrate remaining E2E workflows to the reusable workflow (#14403) ...
matYang
pushed a commit
to smartcontractkit/ccip
that referenced
this pull request
Nov 14, 2024
Optional WS URL for RPCs to unblock new chain integration. Charry-picks from: smartcontractkit/chainlink#14354 smartcontractkit/chainlink#14373 smartcontractkit/chainlink#14534 smartcontractkit/chainlink#14364 smartcontractkit/chainlink#14929 --------- Co-authored-by: Joe Huang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
EVM RPCClient uses web sockets to provide users with nearly real-time access to new blocks. While WS provides better performance, its reliability is sometimes not sufficient. We should be able to use HTTP instead.
In this PR:
NewHeadsPollInterval(>0 indicate the polling new head is enabled), it's done with a separate PR for better readability hopefully.In another PR we make the ws url optional if Logbroadcaster is disabled.
Tickets:
BCFR-706