CCIP-3428 Enabling ccip smoke test for testnet #14452
Conversation
| var duration time.Duration | ||
| deadline, ok := t.Deadline() | ||
| if ok { | ||
| // add a minute to the deadline to ensure we don't miss it |
There was a problem hiding this comment.
Not sure you can tweak a deadline this way - I believe the Go test runner will just kill the test once its past the deadline. Is this what you want?
There was a problem hiding this comment.
Ah I think this comment is a bit misleading, maybe "make the timer end a minute before the deadline so we don't miss it"
|
| deadline, ok := t.Deadline() | ||
| if ok { | ||
| // make this timer end a minute before so that we don't hit the deadline | ||
| duration = deadline.Sub(time.Now().Add(-1 * time.Minute)) |
There was a problem hiding this comment.
What is the downside of hitting the deadline other than failing with a timeout which will happen anyways?
I think seconds should be enough? If the deadline is 5 minutes then 1 minute is 20% of the time. So either make it a percentage of the total deadline 2-5% or just a couple of seconds.
There was a problem hiding this comment.
There's no real downside other than log output after the test times out, the test runtime will print all running goroutines and their stack
| chains = append(chains, ChainConfig{ | ||
| ChainID: uint64(chainId), | ||
| ChainName: chainName, | ||
| ChainType: "EVM", |
| @@ -1,3 +1,7 @@ | |||
| [Common] | |||
| # chainlink node funding in native token | |||
| chainlink_node_funding = 1 | |||
There was a problem hiding this comment.
I see in the other toml chainlink_node_funding = 2 with same comment about native token. What does the number denote exactly in this context?
There was a problem hiding this comment.
Currently it uses same amount of native to fund chainlink nodes across all network. If you are running this in testnet 1 native is not enough(example 1avax), therefore in the testnet testconfig you might have seen this referred as 2. For simulated geth 1 Eth is enough for the course of our test.
There was a problem hiding this comment.
Maybe in subsequent PR add a comment that this is Eth, I mistook it for a config number that gets mapped somewhere
* enabling test for testnet * home chain selector logic * testnet deployment * remove unwanted * lint fix * add readme * fix typo * fix * make timer rely on test deadline * update comment * update comment
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
…tractkit/chainlink into re-2964/goreleaser-ccip * 're-2964/goreleaser-ccip' of https://github.com/smartcontractkit/chainlink: Fix data race in TestLogPoller_Replay (#14431) Fix CCIP Load Test Faulty Fund Return (#14499) use tx in insertLogsWithinTx (#14361) Bring KMS client and multiclient over to chainlink (#14484) CCIP-3420: Fix IsRequestTriggeredWithinTimeframe (#1445) (#14498) [TT-1345] option to use predeployed contracts in OCR tests (#13758) CCIP-3428 Enabling ccip smoke test for testnet (#14452)
Enables initial deployment test for testnet.
With the env vars mentioned in integration-tests/deployment/devenv/.sample.env and the test config integration-tests/testconfig/ccip/overrides/sepolia_avax_binance.toml the existing ccip smoke test can be run against testnets.