Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support passing in a values.Value to the GetLatestValue and QueryKey methods #14488

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Support passing in a values.Value to the GetLatestValue and QueryKey methods #14488

merged 1 commit into from
Sep 25, 2024

Conversation

ettec
Copy link
Collaborator

@ettec ettec commented Sep 18, 2024 •
edited
Loading

@EasterTheBunny
Copy link
Contributor

It makes sense to me so far.

@ettec ettec force-pushed the chainreader-valuemap-as-arg branch from d166306 to cee0014 Compare September 19, 2024 12:57
@ettec ettec changed the title Support passing in a values.Value to the GetLatestValue method Support passing in a values.Value to the GetLatestValue and QueryKey methods Sep 19, 2024
@ettec ettec force-pushed the chainreader-valuemap-as-arg branch 3 times, most recently from c4fed65 to 9f3741f Compare September 19, 2024 17:56
@kidambisrinivas kidambisrinivas marked this pull request as ready for review September 20, 2024 12:30
@kidambisrinivas kidambisrinivas requested review from a team as code owners September 20, 2024 12:30
@kidambisrinivas kidambisrinivas requested review from george-dorin and removed request for a team September 20, 2024 12:30
@ettec ettec force-pushed the chainreader-valuemap-as-arg branch 3 times, most recently from 1c93533 to 67056cc Compare September 25, 2024 08:56
@ettec ettec force-pushed the chainreader-valuemap-as-arg branch from 493704a to b0516dd Compare September 25, 2024 09:00
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
80.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@ettec ettec added this pull request to the merge queue Sep 25, 2024
Merged via the queue into develop with commit 700dd7c Sep 25, 2024
127 checks passed
@ettec ettec deleted the chainreader-valuemap-as-arg branch September 25, 2024 10:06
@github-actions github-actions bot mentioned this pull request Sep 25, 2024
Draft
This was referenced Oct 2, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cedric-cordenier cedric-cordenier cedric-cordenier approved these changes

@kidambisrinivas kidambisrinivas kidambisrinivas approved these changes

@george-dorin george-dorin Awaiting requested review from george-dorin george-dorin is a code owner automatically assigned from smartcontractkit/foundations

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ettec @EasterTheBunny @kidambisrinivas @cedric-cordenier