Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCIP-3171 SelfServeTokenPoolFactory #14924

Merged
merged 10 commits into from
Oct 25, 2024
Merged

Conversation

jhweintraub
Copy link
Collaborator

Self Serve Token Pool Factory copied over from PR in the former CCIP repo

Copy link
Contributor

github-actions bot commented Oct 23, 2024

Solidity Review Jira issue

Hey! We have taken the liberty to link this PR to a Jira issue for Solidity Review.

This is a new feature, that's currently in the pilot phase, so please make sure that the linkage is correct. In a contrary case, please update it manually in JIRA and replace Solidity Review issue key in the changeset file with the correct one.
Please reach out to the Test Tooling team and notify them about any issues you encounter.

Any changes to the Solidity Review Jira issue should be reflected in the changeset file. If you need to update the issue key, please do so manually in the following changeset file: contracts/.changeset/dry-seas-grow.md

This PR has been linked to Solidity Review Jira issue: CCIP-3966

Copy link
Contributor

github-actions bot commented Oct 23, 2024

Static analysis results are available

Hey @jhweintraub, you can view Slither reports in the job summary here or download them as artifact here.
Please check them before merging and make sure you have addressed all issues.

RyanRHall
RyanRHall previously approved these changes Oct 23, 2024
Copy link
Contributor

@RyanRHall RyanRHall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with nits :)

RyanRHall
RyanRHall previously approved these changes Oct 23, 2024
RyanRHall
RyanRHall previously approved these changes Oct 24, 2024
0xsuryansh
0xsuryansh previously approved these changes Oct 24, 2024
@jhweintraub jhweintraub dismissed stale reviews from 0xsuryansh and RyanRHall via cb91a8c October 25, 2024 14:00
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@jhweintraub jhweintraub enabled auto-merge October 25, 2024 15:38
@jhweintraub jhweintraub requested a review from RayXpub October 25, 2024 16:32
@jhweintraub jhweintraub added this pull request to the merge queue Oct 25, 2024
Merged via the queue into develop with commit 161d227 Oct 25, 2024
122 checks passed
@jhweintraub jhweintraub deleted the feat/selfServeTokenPoolFactory branch October 25, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants