[Keystone][Deployments] Make adding NOPs and DONs idempotent #15163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krehermann
reviewed
Nov 8, 2024
deployment/keystone/deploy.go
Outdated
| } | ||
| existingNopsAddrToID := make(map[string]uint32) | ||
| for id, nop := range existingNops { | ||
| existingNopsAddrToID[nop.Admin.String()] = uint32(id) |
There was a problem hiding this comment.
the admin strings are phony in some of our deployments and not unique.
maybe hash the name,addr and use that as the key
There was a problem hiding this comment.
i think you can just use the struct as the key
krehermann
approved these changes
Nov 8, 2024
krehermann
requested changes
Nov 8, 2024
bolekk
force-pushed
the
feature/KS-507-streams-deployment
branch
from
45df325 to
29ba2c1
Compare
Similarly to adding capabilities or nodes, don't add NOPs or DONs that already exist.
bolekk
force-pushed
the
feature/KS-507-streams-deployment
branch
from
29ba2c1 to
939f9f6
Compare
krehermann
approved these changes
Nov 8, 2024
patrickhuie19
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to adding capabilities or nodes, don't add NOPs or DONs that already exist.