deployments: keystone: Leverage job-distributor #15179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see you updated files related to
|
Flaky Test Detector for
|
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
Flaky Test Detector for
|
archseer
force-pushed
the
aptos-deployments
branch
from
a1b409b to
50ea96c
Compare
archseer
force-pushed
the
aptos-deployments
branch
from
50ea96c to
ae89cd6
Compare
jmank88
reviewed
Nov 13, 2024
jmank88
reviewed
Nov 13, 2024
| return &v | ||
| } | ||
|
|
||
| func value[T any](v *T) T { |
There was a problem hiding this comment.
It seems important for this helpers behavior to be clear at call sites:
Suggested change
| func value[T any](v *T) T { | |
| func valOrZero[T any](v *T) T { |
Suggested change
| func value[T any](v *T) T { | |
| func orZero[T any](v *T) T { |
🤷
There was a problem hiding this comment.
sure. can change in followup?
ci is brutal and need to incorporate down streams 🙏
jmank88
approved these changes
Nov 13, 2024
krehermann
approved these changes
Nov 13, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 13, 2024
* deployment: Support other chain types in CreateCCIPOCRSupportedChains * nix: Upgrade to postgres 15 * keystone: Migrate from CLO to JD * CLO compat * Allow setting labels on nodes * Rename function * Tag nodes with p2p_id for easy lookup * Lookup nodes according to p2p_id * Implement label & id filtering in the memory job client * Update the CLO job client as well * go mod tidy * Fix DeployCLO * Fix CLO job client test * add TODOs * fix up tests again * Fix compilation, remove nodeIdToNop indirection * fix TestDeployCLO * add clo utils to bridge tooling gap * add utils to remap clo node id to peer id * fix p2p filter in clo jd impl; fix mis-matched id vs p2p usage * Add credential support to jd client * go mod tidy * rm pointer lib --------- Co-authored-by: krehermann <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supporting chainlink-deployment pr