Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action Remote Shims Register/Unregister #15232

Merged
merged 7 commits into from
Nov 14, 2024
Merged

Action Remote Shims Register/Unregister #15232

merged 7 commits into from
Nov 14, 2024

Conversation

ettec
Copy link
Collaborator

@ettec ettec commented Nov 13, 2024

support for executing an action remotely (executable capability more generally) as part of -> https://smartcontract-it.atlassian.net/browse/CAPPL-108

Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

Copy link
Contributor

Flaky Test Detector for ./go.mod project has failed ❌

Ran new or updated tests between develop and 173e96e (rc-chainlink-shims).

View Flaky Detector Details | Compare Changes

Failed Tests

Ran 49 tests in total for all affected test packages. Below are the tests identified as flaky, with a pass ratio lower than the 100% threshold:

TestPackage                                                                            TestName                            PassRatio  RunCount   Skipped
---------                                                                              ---------                           ---------  ---------  ---------
github.com/smartcontractkit/chainlink/v2/core/capabilities/integration_tests/keystone  Test_AllAtOnceTransmissionSchedule  0%         1          false

Copy link
Contributor

github-actions bot commented Nov 13, 2024

AER Report: CI Core

aer_workflow , commit , Detect Changes , Scheduled Run Frequency , Clean Go Tidy & Generate , Find New Flaky Tests In Root Project / Find Tests To Run , lint , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_race_tests) , Core Tests (go_core_fuzz) , Find New Flaky Tests In Root Project / Run Tests (github.com/smartcontractkit/chainlink/v2/core/capabilities/transmission) , Find New Flaky Tests In Root Project / Run Tests (github.com/smartcontractkit/chainlink/v2/core/capabilities) , Find New Flaky Tests In Root Project / Run Tests (github.com/smartcontractkit/chainlink/v2/core/capabilities/remote/executable) , Find New Flaky Tests In Deployment Project / Find Tests To Run , Find New Flaky Tests In Root Project / Report , Find New Flaky Tests In Deployment Project / Run Tests , Find New Flaky Tests In Deployment Project / Report , Flakey Test Detection , SonarQube Scan

1. Test failures encountered: go_core_tests

Source of Error:
Run tests	2024-11-14T14:22:40.9478297Z Encountered test failures.
Run tests	2024-11-14T14:22:40.9480657Z go_core_tests exiting with code 1
Run tests	2024-11-14T14:22:40.9594080Z ##[error]Process completed with exit code 1.

Why: The error indicates that the go_core_tests job encountered test failures, which caused the process to exit with a non-zero exit code (1). This is a common indication that one or more tests did not pass successfully.

Suggested fix: Review the test output to identify which specific tests failed and address the underlying issues in the code or test cases. Ensure all dependencies and configurations are correctly set up for the tests to pass.

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@ettec ettec marked this pull request as ready for review November 14, 2024 09:46
@ettec ettec requested review from a team as code owners November 14, 2024 09:46
@ettec ettec requested a review from patrickhuie19 November 14, 2024 09:46
Copy link
Contributor

@cedric-cordenier cedric-cordenier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% keen on how we are mixing concepts Executable capability vs Action/Consensus/Target etc within the same level of the API (the config we store in the capabilities registry)

However I'm not going to block the PR on this

@ettec ettec force-pushed the rc-chainlink-shims branch from f0acf09 to 44f3654 Compare November 14, 2024 13:51
@ettec
Copy link
Collaborator Author

ettec commented Nov 14, 2024

I'm not 100% keen on how we are mixing concepts Executable capability vs Action/Consensus/Target etc within the same level of the API (the config we store in the capabilities registry)

However I'm not going to block the PR on this

issue raised on this to track so we can come back to later-> https://smartcontract-it.atlassian.net/browse/CAPPL-291

@justinkaseman justinkaseman self-requested a review November 14, 2024 18:54
@ettec ettec added this pull request to the merge queue Nov 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 14, 2024
@ettec ettec added this pull request to the merge queue Nov 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 14, 2024
@ettec ettec added this pull request to the merge queue Nov 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 14, 2024
@ettec ettec added this pull request to the merge queue Nov 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 14, 2024
@ettec ettec added this pull request to the merge queue Nov 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 14, 2024
@ettec ettec added this pull request to the merge queue Nov 14, 2024
Merged via the queue into develop with commit c015da8 Nov 14, 2024
142 of 144 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants