Capability Encoder changes to use PreCodec #15538
Merged
+142
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
justinkaseman
force-pushed
the
CAPPL-318
branch
from
f7f36f5 to
13fed44
Compare
justinkaseman
force-pushed
the
CAPPL-318
branch
from
13fed44 to
e371b73
Compare
| @@ -46,8 +48,22 @@ func NewEVMEncoder(config *values.Map) (consensustypes.Encoder, error) { | |||
| return nil, err | |||
| } | |||
|
|
|||
| var subabi map[string]string | |||
| err = config.Underlying[subabiConfigFieldName].UnwrapTo(subabi) | |||
There was a problem hiding this comment.
Could be shortened to:
type configStruct struct {
subapiConfigFieldName map[string]string
}
config.UnwrapTo(&configStruct{})
There was a problem hiding this comment.
Didn't make this change. May no longer be relevant because subabi is optional. Check this again.
cedric-cordenier
previously approved these changes
Dec 6, 2024
ilija42
previously approved these changes
Dec 13, 2024
justinkaseman
dismissed stale reviews from ilija42 and cedric-cordenier
via
a22b8f1
justinkaseman
changed the title
ettec
approved these changes
Dec 16, 2024
cedric-cordenier
approved these changes
Dec 16, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires
Depends on this PR being merged & then chainlink-common dependency being bumped again
Supports
Core changes for smartcontractkit/chainlink-common#961