CCIP-4058 replace f with fObserve and fSign in RMHome and RMNRemote #15605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Static analysis results are availableHey @jhweintraub, you can view Slither reports in the job summary here or download them as artifact here. |
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
jhweintraub
requested review from
winder,
rstout,
asoliman92,
makramkd,
dimkouv,
mateusz-sekara and
b-gopalswami
jhweintraub
changed the title
makramkd
previously approved these changes
Jan 9, 2025
dimkouv
previously approved these changes
Jan 9, 2025
RensR
reviewed
Jan 9, 2025
makramkd
previously approved these changes
Jan 9, 2025
RensR
previously approved these changes
Jan 9, 2025
0xsuryansh
previously approved these changes
Jan 9, 2025
jhweintraub
dismissed stale reviews from 0xsuryansh, RensR, and makramkd
via
3180337
jmank88
approved these changes
Jan 9, 2025
dimkouv
approved these changes
Jan 9, 2025
|
0xsuryansh
approved these changes
Jan 9, 2025
auto-merge was automatically disabled
January 9, 2025 16:30
Pull Request is not mergeable
auto-merge was automatically disabled
January 9, 2025 16:30
Pull Request is not mergeable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace RMN Configs
fwithfObserveinRMNHomeandfSigninRMNRemoteto be more descriptive and modify all tests as well as update the relevant ones to use the new test naming guide.