Hotfixes (histogram buckets + hex name + engine beholder metrics) #15626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* wiring engine histogram buckets through to beholder Client * bumping common * Move metric views (#15515) * bumping common --------- Co-authored-by: Pavel <[email protected]>
* Adds metrics on workflow engine * Adds trigger event metric * Removes comment * metrics: execution duration histograms by status and removing now redundant instrumentation * adding step execution time histogram * fixing data race for global instruments * cleanup + fixing tests * renaming vars somehow fixes broken test * removing short circuit in workferForStepRequest if Vertex call fails * nil guard if Vertex errs * updating workflow.name to workflow.hexName and fixing err log --------- Co-authored-by: patrickhuie19 <[email protected]>
bolekk
changed the title
|
I see you updated files related to
|
| @@ -104,6 +104,7 @@ require ( | |||
| go.opentelemetry.io/contrib/instrumentation/github.com/gin-gonic/gin/otelgin v0.49.0 | |||
| go.opentelemetry.io/otel v1.31.0 | |||
| go.opentelemetry.io/otel/metric v1.31.0 | |||
| go.opentelemetry.io/otel/sdk/metric v1.31.0 | |||
There was a problem hiding this comment.
this didn't come with a corresponding go.sum change?
There was a problem hiding this comment.
No because it's still included, just sorted differently.
patrickhuie19
approved these changes
Dec 11, 2024
AER Report: CI Core ran successfully ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.