feat: add changeset for set config on all 3 mcms contracts [DPA-1392] #15684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krehermann
reviewed
Dec 13, 2024
krehermann
reviewed
Dec 13, 2024
AER Report: CI Core ran successfully ✅ |
graham-chainlink
approved these changes
Dec 17, 2024
krehermann
reviewed
Dec 17, 2024
| if !useMCMS { | ||
| _, err = deployment.ConfirmIfNoError(chain, tx, err) | ||
| if err != nil { | ||
| return nil, err |
There was a problem hiding this comment.
use something like this or this
chainlink/deployment/helpers.go
Line 90 in fd9d5de
can be done in a quick follow up
krehermann
reviewed
Dec 17, 2024
| chain := env.Chains[chainSelector] | ||
| addrs, err := env.ExistingAddresses.AddressesForChain(chainSelector) | ||
| require.NoError(t, err) | ||
| require.Len(t, addrs, 6) |
There was a problem hiding this comment.
nit/ add comment about what the 6 contracts are for future readers
krehermann
approved these changes
Dec 17, 2024
connorwstein
approved these changes
Dec 17, 2024
george-dorin
pushed a commit
that referenced
this pull request
Jan 13, 2025
…#15684) * feat: add changeset for set config on all 3 mcms contracts * fix: use _test package and change ctx function. * fix: formatting and comments * fix: unit tests set config * fix: check different configs per role. * fix: pass context and add info logs for success
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DPA-1392
Support SetConfig calls either via an mcms proposal or directly executing the transactions. The changeset will call setConfig on the proposer, bypasser and canceller mcms contract that is set on the address book for each chain provided in the config.