delve support

[skudasov]

Add delve support for plugins image

[cedric-cordenier]

Is this a potential security risk? 🤔 exposing a debugger port by default seems like it could be unsafe. Afaik we do ship this image to NOPs
.

[github-actions]

AER Report: CI Core

aer_workflow , commit , Detect Changes , Clean Go Tidy & Generate , Scheduled Run Frequency , Flakeguard Root Project / Get Tests To Run , lint , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Flakeguard Deployment Project , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_race_tests) , Core Tests (go_core_fuzz) , Flakeguard Root Project / Run Tests , Flakeguard Root Project / Report , Flakey Test Detection , SonarQube Scan

1. Error stopping job service:[go_core_ccip_deployment_tests]

Source of Error:

Run tests	2024-12-17T11:58:04.0702400Z logger.go:146: 2024-12-17T11:57:34.271Z	DPANIC	JobSpawner	job/spawner.go:175	Error stopping job service	{"version": "unset@unset", "jobID": 1, "subservice": 3, "serviceType": "*launcher.launcher", "err": "failed to close RMN home reader: has already been stopped: already stopped; failed to close RMN home reader: has already been stopped: already stopped", "errCauses": [{"error": "failed to close RMN home reader: has already been stopped: already stopped"}, {"error": "failed to close RMN home reader: has already been stopped: already stopped"}]}
Run tests	2024-12-17T11:58:04.0704451Z github.com/smartcontractkit/chainlink/v2/core/services/job.(*spawner).stopService
Run tests	2024-12-17T11:58:04.0705223Z 	/home/runner/work/chainlink/chainlink/core/services/job/spawner.go:175
Run tests	2024-12-17T11:58:04.0706135Z github.com/smartcontractkit/chainlink/v2/core/services/job.(*spawner).stopAllServices
Run tests	2024-12-17T11:58:04.0706984Z 	/home/runner/work/chainlink/chainlink/core/services/job/spawner.go:152
Run tests	2024-12-17T11:58:04.0707732Z github.com/smartcontractkit/chainlink/v2/core/services/job.(*spawner).Close.func1
Run tests	2024-12-17T11:58:04.0708488Z 	/home/runner/work/chainlink/chainlink/core/services/job/spawner.go:114
Run tests	2024-12-17T11:58:04.0709242Z github.com/smartcontractkit/chainlink-common/pkg/services.(*StateMachine).StopOnce
Run tests	2024-12-17T11:58:04.0710375Z 	/home/runner/go/pkg/mod/github.com/smartcontractkit/[email protected]/pkg/services/state.go:132
Run tests	2024-12-17T11:58:04.0711295Z github.com/smartcontractkit/chainlink/v2/core/services/job.(*spawner).Close
Run tests	2024-12-17T11:58:04.0712114Z 	/home/runner/work/chainlink/chainlink/core/services/job/spawner.go:112
Run tests	2024-12-17T11:58:04.0712992Z github.com/smartcontractkit/chainlink/v2/core/services/chainlink.(*ChainlinkApplication).stop.func1
Run tests	2024-12-17T11:58:04.0713895Z 	/home/runner/work/chainlink/chainlink/core/services/chainlink/application.go:824
Run tests	2024-12-17T11:58:04.0714370Z sync.(*Once).doSlow
Run tests	2024-12-17T11:58:04.0715084Z 	/home/runner/go/pkg/mod/golang.org/[email protected]/src/sync/once.go:76
Run tests	2024-12-17T11:58:04.0715564Z sync.(*Once).Do
Run tests	2024-12-17T11:58:04.0716247Z 	/home/runner/go/pkg/mod/golang.org/[email protected]/src/sync/once.go:67
Run tests	2024-12-17T11:58:04.0717210Z github.com/smartcontractkit/chainlink/v2/core/services/chainlink.(*ChainlinkApplication).stop
Run tests	2024-12-17T11:58:04.0718077Z 	/home/runner/work/chainlink/chainlink/core/services/chainlink/application.go:809
Run tests	2024-12-17T11:58:04.0718948Z github.com/smartcontractkit/chainlink/v2/core/services/chainlink.(*ChainlinkApplication).Stop
Run tests	2024-12-17T11:58:04.0719821Z 	/home/runner/work/chainlink/chainlink/core/services/chainlink/application.go:802
Run tests	2024-12-17T11:58:04.0720754Z github.com/smartcontractkit/chainlink/deployment/ccip/changeset.(*MemoryEnvironment).StartNodes.func1
Run tests	2024-12-17T11:58:04.0721708Z 	/home/runner/work/chainlink/chainlink/deployment/ccip/changeset/test_environment.go:237
Run tests	2024-12-17T11:58:04.0722260Z testing.(*common).Cleanup.func1
Run tests	2024-12-17T11:58:04.0723053Z 	/home/runner/go/pkg/mod/golang.org/[email protected]/src/testing/testing.go:1176
Run tests	2024-12-17T11:58:04.0723620Z testing.(*common).runCleanup
Run tests	2024-12-17T11:58:04.0724382Z 	/home/runner/go/pkg/mod/golang.org/[email protected]/src/testing/testing.go:1354
Run tests	2024-12-17T11:58:04.0724907Z testing.tRunner.func2
Run tests	2024-12-17T11:58:04.0725764Z 	/home/runner/go/pkg/mod/golang.org/[email protected]/src/testing/testing.go:1684
Run tests	2024-12-17T11:58:04.0726271Z runtime.Goexit
Run tests	2024-12-17T11:58:04.0726986Z 	/home/runner/go/pkg/mod/golang.org/[email protected]/src/runtime/panic.go:629
Run tests	2024-12-17T11:58:04.0727526Z testing.(*common).FailNow
Run tests	2024-12-17T11:58:04.0728281Z 	/home/runner/go/pkg/mod/golang.org/[email protected]/src/testing/testing.go:1006
Run tests	2024-12-17T11:58:04.0728904Z github.com/stretchr/testify/require.Eventually
Run tests	2024-12-17T11:58:04.0729607Z 	/home/runner/go/pkg/mod/github.com/stretchr/[email protected]/require/require.go:401
Run tests	2024-12-17T11:58:04.0730540Z github.com/smartcontractkit/chainlink/deployment/ccip/changeset.ConfirmCommitForAllWithExpectedSeqNums
Run tests	2024-12-17T11:58:04.0731502Z 	/home/runner/work/chainlink/chainlink/deployment/ccip/changeset/test_assertions.go:216
Run tests	2024-12-17T11:58:04.0732421Z github.com/smartcontractkit/chainlink/deployment/ccip/changeset.TestInitialAddChainAppliedTwice
Run tests	2024-12-17T11:58:04.0733406Z 	/home/runner/work/chainlink/chainlink/deployment/ccip/changeset/cs_initial_add_chain_test.go:91
Run tests	2024-12-17T11:58:04.0734078Z testing.tRunner
Run tests	2024-12-17T11:58:04.0734879Z 	/home/runner/go/pkg/mod/golang.org/[email protected]/src/testing/testing.go:1690

Why: The error occurred because the job service attempted to stop a subservice that had already been stopped. This resulted in a panic due to the redundant stop operation.

Suggested fix: Ensure that the service stop logic checks if the service is already stopped before attempting to stop it again. This can be done by adding a state check before the stop operation.

2. Error reading from connection:[go_core_ccip_deployment_tests]

Source of Error:

Run tests	2024-12-17T11:58:03.9994850Z logger.go:146: 2024-12-17T11:57:34.260Z	WARN	SingletonPeerWrapper	ragep2p/ragep2p.go:1251	Error reading from connection	{"version": "unset@unset", "peerID": "12D3KooWECLdzkhvzFjKB95UKsANiHAfiw9Jkzjx5szHe6Jx196h", "id": "ragep2p", "remotePeerID": "12D3KooWKqsRwQsawWCdpdFNwGXsadasuUmMf1thbhvVeaQggm2z", "remoteAddr": "127.0.0.1:43494", "direction": "in", "error": "EOF"}
Run tests	2024-12-17T11:58:03.9998140Z logger.go:146: 2024-12-17T11:57:34.260Z	WARN	SingletonPeerWrapper	ragep2p/ragep2p.go:1251	Error reading from connection	{"version": "unset@unset", "direction": "out", "remoteAddr": "127.0.0.1:26601", "peerID": "12D3KooWKqsRwQsawWCdpdFNwGXsadasuUmMf1thbhvVeaQggm2z", "error": "read tcp 127.0.0.1:43494->127.0.0.1:26601: use of closed network connection", "remotePeerID": "12D3KooWECLdzkhvzFjKB95UKsANiHAfiw9Jkzjx5szHe6Jx196h", "id": "ragep2p"}

Why: The error occurred because the connection was closed while there were still attempts to read from it, resulting in an EOF (End of File) error.

Suggested fix: Ensure that all read operations are properly synchronized with the connection closure. Implement checks to confirm that the connection is open before attempting to read from it.

3. Error reading from connection:[go_core_ccip_deployment_tests]

Source of Error:

Run tests	2024-12-17T11:58:04.0063714Z logger.go:146: 2024-12-17T11:57:34.260Z	WARN	SingletonPeerWrapper	ragep2p/ragep2p.go:1251	Error reading from connection	{"version": "unset@unset", "remotePeerID": "12D3KooWKqsRwQsawWCdpdFNwGXsadasuUmMf1thbhvVeaQggm2z", "direction": "in", "remoteAddr": "127.0.0.1:56960", "id": "ragep2p", "peerID": "12D3KooWGji6UjZhyy13prNQQXBcHoS61BRk1c7TtxdEqnnTsaU8", "error": "EOF"}
Run tests	2024-12-17T11:58:04.0066863Z logger.go:146: 2024-12-17T11:57:34.260Z	WARN	SingletonPeerWrapper	ragep2p/ragep2p.go:1251	Error reading from connection	{"version": "unset@unset", "remotePeerID": "12D3KooWGji6UjZhyy13prNQQXBcHoS61BRk1c7TtxdEqnnTsaU8", "direction": "out", "remoteAddr": "127.0.0.1:26600", "error": "read tcp 127.0.0.1:56960->127.0.0.1:26600: use of closed network connection", "id": "ragep2p", "peerID": "12D3KooWKqsRwQsawWCdpdFNwGXsadasuUmMf1thbhvVeaQggm2z"}

Why: Similar to the previous error, this occurred because the connection was closed while read operations were still being attempted, leading to an EOF error.

Suggested fix: Implement proper synchronization to ensure that read operations are only performed on open connections. Add checks to verify the connection status before reading.

4. Error reading from connection:[go_core_ccip_deployment_tests]

Source of Error:

Run tests	2024-12-17T11:58:04.0473485Z logger.go:146: 2024-12-17T11:57:34.266Z	WARN	SingletonPeerWrapper	ragep2p/ragep2p.go:1251	Error reading from connection	{"version": "unset@unset", "remoteAddr": "127.0.0.1:56930", "id": "ragep2p", "peerID": "12D3KooWGji6UjZhyy13prNQQXBcHoS61BRk1c7TtxdEqnnTsaU8", "remotePeerID": "12D3KooWECLdzkhvzFjKB95UKsANiHAfiw9Jkzjx5szHe6Jx196h", "direction": "in", "error": "EOF"}
Run tests	2024-12-17T11:58:04.0481415Z logger.go:146: 2024-12-17T11:57:34.266Z	WARN	SingletonPeerWrapper	ragep2p/ragep2p.go:1251	Error reading from connection	{"version": "unset@unset", "direction": "out", "remoteAddr": "127.0.0.1:26600", "peerID": "12D3KooWECLdzkhvzFjKB95UKsANiHAfiw9Jkzjx5szHe6Jx196h", "id": "ragep2p", "remotePeerID": "12D3KooWGji6UjZhyy13prNQQXBcHoS61BRk1c7TtxdEqnnTsaU8", "error": "read tcp 127.0.0.1:56930->127.0.0.1:26600: use of closed network connection"}

Why: This error is also due to attempts to read from a connection that has already been closed, resulting in an EOF error.

Suggested fix: Similar to the previous fixes, ensure that read operations are synchronized with connection status checks to avoid reading from closed connections.