Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/internal/features/ocr2: isolate non-parallel test in separate package #15722

Merged
merged 1 commit into from
Dec 17, 2024
Merged

core/internal/features/ocr2: isolate non-parallel test in separate package #15722

merged 1 commit into from
Dec 17, 2024
+742 −689

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented Dec 16, 2024 •
edited
Loading

Refactoring tests that set env vars to separate packages in order to run them in parallel.

@jmank88 jmank88 requested a review from erikburt December 16, 2024 22:38
@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

jmank88
jmank88 commented Dec 16, 2024
View reviewed changes
core/internal/features/ocr2/internal/features_ocr2.go Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all just moved with the only refactor being exporting names.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 16, 2024 •
edited
Loading

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@jmank88 jmank88 force-pushed the features-ocr2-test-par branch 3 times, most recently from 67a8a88 to a11a24c Compare December 16, 2024 23:49
@jmank88 jmank88 marked this pull request as ready for review December 17, 2024 00:05
@jmank88 jmank88 requested review from a team as code owners December 17, 2024 00:05
@jmank88 jmank88 requested a review from chudilka1 December 17, 2024 00:05
@jmank88 jmank88 enabled auto-merge December 17, 2024 00:08
@jmank88 jmank88 force-pushed the features-ocr2-test-par branch from a11a24c to 853a2e3 Compare December 17, 2024 00:21
@jmank88 jmank88 added this pull request to the merge queue Dec 17, 2024
Merged via the queue into develop with commit 85c8b96 Dec 17, 2024
170 of 171 checks passed
@jmank88 jmank88 deleted the features-ocr2-test-par branch December 17, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krehermann krehermann krehermann approved these changes

@erikburt erikburt erikburt approved these changes

@chudilka1 chudilka1 Awaiting requested review from chudilka1 chudilka1 is a code owner automatically assigned from smartcontractkit/foundations

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmank88 @erikburt @krehermann