Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test snapshot exclusion #15727

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

Fix test snapshot exclusion #15727

wants to merge 9 commits into from

Conversation

RensR
Copy link
Contributor

@RensR RensR commented Dec 17, 2024

This PR cleans up the base contracts for all tests, removing the MockRMN in favor of RMNRemote and moving logic further up the inheritance chain. This should result in (minor) compilation gains. This PR also renames the reverts tests to _RevertWhen_ tests so the snapshot excludes them. This was done using regex so not all names are perfect. The ongoing initiative of fixing all test names in any file you touch should continue, but at least we've addresses the snapshot part of it.

This PR

➜  contracts git:(fix-test-naming) forge build --no-cache     
[⠊] Compiling...
[⠊] Compiling 386 files with Solc 0.8.24
[⠆] Solc 0.8.24 finished in 101.08s
Compiler run successful!
➜  contracts git:(fix-test-naming) forge build --no-cache
[⠊] Compiling...
[⠒] Compiling 386 files with Solc 0.8.24
[⠘] Solc 0.8.24 finished in 98.60s
Compiler run successful!

Develop

➜  contracts git:(develop) forge build --no-cache
[⠊] Compiling...
[⠔] Compiling 388 files with Solc 0.8.24
[⠑] Solc 0.8.24 finished in 102.75s
Compiler run successful!
➜  contracts git:(develop) forge build --no-cache
[⠊] Compiling...
[⠢] Compiling 388 files with Solc 0.8.24
[⠰] Solc 0.8.24 finished in 99.21s
Compiler run successful!

It appears to be ~1% faster while improving our test suite.

@RensR RensR requested a review from a team as a code owner December 17, 2024 09:50
Copy link
Contributor

github-actions bot commented Dec 17, 2024

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

Copy link
Contributor

github-actions bot commented Dec 17, 2024

Static analysis results are available

Hey @RensR, you can view Slither reports in the job summary here or download them as artifact here.
Please check them before merging and make sure you have addressed all issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant