[CAPPL-434] feat(deployment/keystone): addNodes generate MCMS proposal #16098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MStreet3
force-pushed
the
cappl-434/add-nodes-mcms-call
branch
2 times, most recently
from
5fa0a52 to
b596412
Compare
MStreet3
changed the title
MStreet3
force-pushed
the
cappl-434/add-nodes-mcms-call
branch
from
b596412 to
1221781
Compare
MStreet3
force-pushed
the
cappl-434/add-nodes-mcms-call
branch
from
483ea09 to
380aa0e
Compare
MStreet3
force-pushed
the
cappl-434/add-nodes-mcms-call
branch
from
380aa0e to
5ef674e
Compare
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
MStreet3
force-pushed
the
cappl-434/add-nodes-mcms-call
branch
from
5ef674e to
2f273fd
Compare
MStreet3
force-pushed
the
cappl-434/add-nodes-mcms-call
branch
2 times, most recently
from
e137571 to
8e13abe
Compare
MStreet3
commented
Jan 30, 2025
| @@ -111,7 +111,7 @@ abigen: ## Build & install abigen. | |||
| .PHONY: generate | |||
| generate: abigen codecgen mockery protoc gomods ## Execute all go:generate commands. | |||
| ## Updating PATH makes sure that go:generate uses the version of protoc installed by the protoc make command. | |||
| export PATH=$(HOME)/.local/bin:$(PATH); gomods -w go generate -x ./... | |||
| export PATH="$(HOME)/.local/bin:$(PATH)"; gomods -w go generate -x ./... | |||
There was a problem hiding this comment.
prevents failure due to Visual Studio Code.app in PATH.
cedric-cordenier
previously approved these changes
Jan 30, 2025
MStreet3
commented
Jan 30, 2025
| uniqueNodeParams = append(uniqueNodeParams, v) | ||
| lggr.Debugw("checking for existing nodes", "count", len(nodeIDToParams)) | ||
|
|
||
| nodes2Add, err := getNodesToRegister(registry, nodeIDToParams) |
There was a problem hiding this comment.
only register nodes not on the contract
agparadiso
previously approved these changes
Jan 30, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
MStreet3
dismissed stale reviews from krehermann, agparadiso, and cedric-cordenier
via
9006f57
cedric-cordenier
previously approved these changes
Jan 30, 2025
krehermann
previously approved these changes
Jan 30, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 30, 2025
#16098) * fix(keystone/changeset): register nodes via mcms proposal * fix(keystone/changeset): adds unit test for add don mcms proposal * refactor(keyston/changeset): minor refactor * fix(keystone/changeset): lint test file * fix path spec in GNUMakefile * fix(deployment/keystone): find nodes to compare instead of iterate
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
MStreet3
dismissed stale reviews from krehermann and cedric-cordenier
via
51f7b29
justinkaseman
approved these changes
Jan 30, 2025
|
krehermann
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables MCMS proposal generation for AddNodes and AddDONs on the CapabilityRegistry. If there are no new nodes to add or no new DONs to add, then the MCMS ops are empty.
Requires
Supports