Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ship-3971] remove ws dep ccip #16143

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

davidcauchi
Copy link
Contributor

@davidcauchi davidcauchi commented Jan 30, 2025

- Pulls back in Grafana and Loki configs
- Adds in missing config
- Integrates Sentinel to allow for polling for fetching events in CCIP QA tests.

SHIP-3971

@davidcauchi davidcauchi force-pushed the ship-3971-remove-ws-dep-ccip branch from 87184b4 to 8f74051 Compare January 30, 2025 13:43
Copy link
Contributor

github-actions bot commented Jan 30, 2025

AER Report: CI Core

aer_workflow , commit , Detect Changes , Clean Go Tidy & Generate , Scheduled Run Frequency , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , GolangCI Lint (integration-tests) , Core Tests (go_core_fuzz) , Core Tests (go_core_race_tests) , test-scripts , SonarQube Scan , lint

1. Unnecessary trailing newline error: Golang Lint (integration-tests)

Source of Error:
Golang Lint (integration-tests) 2025-01-30T18:26:41.8247223Z ##[error]integration-tests/ccip-tests/testsetups/ccip.go:1312:1: unnecessary trailing newline (whitespace)
Golang Lint (integration-tests) 2025-01-30T18:26:41.8247839Z 
Golang Lint (integration-tests) 2025-01-30T18:26:41.8248186Z ^

Why: The linter detected an unnecessary trailing newline at line 1312 in the file integration-tests/ccip-tests/testsetups/ccip.go.

Suggested fix: Remove the trailing newline at the end of the file integration-tests/ccip-tests/testsetups/ccip.go to comply with the linter's requirements.

2. Go module updates needed: make generate

Source of Error:
make generate 2025-01-30T18:29:33.2237681Z go: updates to go.mod needed; to update it:
make generate 2025-01-30T18:29:33.2237784Z go mod tidy
make generate 2025-01-30T18:29:33.2237888Z error: exit status 1

Why: The go mod tidy command needs to be run to update the go.mod file with the necessary dependencies.

Suggested fix: Run go mod tidy to update the go.mod file and ensure all dependencies are correctly listed.

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@davidcauchi davidcauchi changed the title Ship 3971 remove ws dep ccip [ship-3971] remove ws dep ccip Jan 30, 2025
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant