Add and fix CRD support #5
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidfestal
commented
Mar 24, 2021
| @@ -115,6 +115,8 @@ func (c *crConverter) ConvertFieldLabel(gvk schema.GroupVersionKind, label, valu | |||
| return label, value, nil | |||
| case !c.clusterScoped && label == "metadata.namespace": | |||
| return label, value, nil | |||
| case gvk.Kind == "Pod" && label == "spec.nodeName": | |||
There was a problem hiding this comment.
This is in fact an unrelated change that should be removed. I did it when trying to plug virtual-kubelet directly to KCP.
But obviously this should be fixed more widely in the future by enabling all possible fields in the filters for CRDs according to the CRD schema as we discussed.
Signed-off-by: David Festal <[email protected]>
... to allow `controller-gen` to generate CRDs for core v1 resources that are not part pf the controlplane corev1 resources. Signed-off-by: David Festal <[email protected]>
Signed-off-by: David Festal <[email protected]>
Signed-off-by: David Festal <[email protected]>
This doesn''t fully work due to the fact that for now CRD don't support strategic merge patch. The fix for this will be in a next commit. Signed-off-by: David Festal <[email protected]>
Signed-off-by: David Festal <[email protected]>
Signed-off-by: David Festal <[email protected]>
Signed-off-by: David Festal <[email protected]>
... since they are used as `patchMergeKey` and in the newly-added `listMapKeys` Signed-off-by: David Festal <[email protected]>
Signed-off-by: David Festal <[email protected]>
... For legacy schema resources that are *not* in the core group. Because the group can be totally absent from the main gorestful registered web services in the main API server (typically `apps/v1` in the case of a control plane api-server) Signed-off-by: David Festal <[email protected]>
|
@smarterclayton it would be great to have your review here, at least to know whether these changes, albeits hacks, are on the right track, or completely wrong... |
Signed-off-by: David Festal <[email protected]>
Signed-off-by: David Festal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.