Merge pull request #75 from smartprocure/fix/remove_errors

[DRAFT] FIX: update errors properly for remove()

CHANGELOG.md

@@ -1,3 +1,7 @@
+# 0.14.2
+
+- FIX: remove() removes all errors, not just the removed field.
+
 # 0.14.1
 
 - FIX: errors[''] is nothing special, remove special handling for it.

package.json

@@ -1,6 +1,6 @@
 {
   "name": "mobx-autoform",
-  "version": "0.14.1",
+  "version": "0.14.2",
   "description": "Ridiculously simple form state management with mobx",
   "type": "module",
   "main": "dist/cjs/index.js",

src/index.js

@@ -118,7 +118,7 @@ export default ({
           F.unsetOn(node.field, parent[keys.fields])
         }
         // Clean errors for this field and all subfields
-        state.errors = omitByPrefixes(dotPath, state.errors)
+        state.errors = omitByPrefixes([dotPath], state.errors)
       },
     })
     node.path = rootPath

src/index.test.js

@@ -185,10 +185,13 @@ describe('Methods and computeds', () => {
   })
 
   it('remove()', () => {
+    form.validate()
+    expect(_.size(form.errors)).toBe(2)
     form.getField('location.addresses.0.tenants.0').remove()
     let tenants = form.getField('location.addresses.0.tenants')
     expect(tenants.fields).toEqual([])
     expect(tenants.value).toEqual([])
+    expect(_.size(form.errors)).toBe(1)
 
     tenants.remove()
     expect(form.getField('location.addresses.0.tenants')).toBeUndefined()