Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Update errors correctly on array item remove #76

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

sandhya-spend
Copy link
Contributor

Follow up upon #75

When an array item is removed, the error associated with that array item needs to be removed, and the rest of the errors in the array need to be moved up.

@sandhya-spend sandhya-spend self-assigned this Nov 15, 2024
@decrapifier
Copy link
Contributor

Warnings
⚠️ You should add at least 1 more reviewer to the PR

Coverage Report

👍 Test coverage is looking good.

Files % Stmts % Branch % Funcs % Lines Uncovered Lines
src/futil.js 100 100 100 100
src/index.js 100 96.88 96.77 100
src/mobx.js 94.87 88.24 100 94.87 10, 11
and 2 more...
Files % Stmts % Branch % Funcs % Lines Uncovered Lines
src/util.js 100 100 100 100
src/validators.js 52.38 100 50 52.38 6, 7, 8, 9, 10, 11, 12, 13, 14, 15

Generated by 🚫 dangerJS against 445c877

@decrapifier
Copy link
Contributor

Coverage Report

👍 Test coverage is looking good.

Files % Stmts % Branch % Funcs % Lines Uncovered Lines
src/futil.js 100 100 100 100
src/index.js 100 96.88 96.77 100
src/mobx.js 94.87 88.24 100 94.87 10, 11
and 2 more...
Files % Stmts % Branch % Funcs % Lines Uncovered Lines
src/util.js 100 100 100 100
src/validators.js 52.38 100 50 52.38 6, 7, 8, 9, 10, 11, 12, 13, 14, 15

Generated by 🚫 dangerJS against fbdc376

Copy link
Member

@stellarhoof stellarhoof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job 👏

@stellarhoof stellarhoof merged commit 7cbdfdf into master Nov 22, 2024
2 checks passed
@stellarhoof stellarhoof deleted the fix/remove_array_errors branch November 22, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants