feat: support explictly null set in model(poc) #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sczlog
force-pushed
the
explictly-json
branch
2 times, most recently
from
cca0cbd to
cf610d6
Compare
Sczlog
force-pushed
the
explictly-json
branch
from
cf610d6 to
fd11665
Compare
fanyang89
reviewed
Jan 14, 2025
| if (!field.canAccess(value)) { | ||
| field.setAccessible(true); | ||
| } | ||
| fieldValue = field.get(value); |
There was a problem hiding this comment.
为啥 private field 还需要被序列化？我看常见的做法是只处理 public getter/setter
There was a problem hiding this comment.
我试了一下，发现 getter 来获取其实不太方便，因为 getter 本质还是一个 function，没法准确的通过是否以 get 开头就是 getter 的逻辑来推断一个方法一定是 getter。。。
感觉通过 private field + annotation 判断的方法更加稳妥一点。
There was a problem hiding this comment.
emmm，看了一下，是能解决如何推断 getter，但是我还需要 annotation 的 value orz
There was a problem hiding this comment.
不过我现在想我是不是该放弃反射，给每个类单独生成一个 Adapter
fanyang89
reviewed
Jan 15, 2025
| private final static String IS_PRESENT = "_isPresent_"; | ||
|
|
||
| public static class ConditionalNullablePojo { | ||
| protected Set<String> _isPresent_ = new HashSet<String>(); |
There was a problem hiding this comment.
避免和潜在的可能字段冲突，用 _ 当 prefix 过滤一层，在自己这边不在 api 参数中定义 _ 前缀的字段
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add ConditionalNullablePojo and type adapter
self test serialize and deserialize