Removed the use of enums for format field using string instead (#40)

smartystreets · Nov 3, 2023 · 423e842 · 423e842
1 parent da543fe
commit 423e842
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 23 deletions.
diff --git a/src/sdk/USStreetApi/Client.cs b/src/sdk/USStreetApi/Client.cs
@@ -72,8 +72,7 @@ private static void PopulateQueryString(Lookup address, Request request)
 			if (address.MaxCandidates != 1) 
 				request.SetParameter("candidates", address.MaxCandidates.ToString(CultureInfo.InvariantCulture));
 
-			if (address.GetFormatString() != "default")
-				request.SetParameter("format", address.GetFormatString());
+			request.SetParameter("format", address.OutputFormat);
 		}
 
 		private static void AssignCandidatesToLookups(Batch batch, IEnumerable<Candidate> candidates)

diff --git a/src/sdk/USStreetApi/Lookup.cs b/src/sdk/USStreetApi/Lookup.cs
@@ -15,12 +15,9 @@ public class Lookup : ILookup
 		public const string ENHANCED = "enhanced";
 		public const string INVALID = "invalid";
 		public const string RANGE = "range"; // Deprecated
-
-		public enum Format
-		{
-			Default,
-			ProjectUsa,
-		}
+
+		public const string DEFAULT_FORMAT = "default";
+		public const string PROJECT_USA_FORMAT = "project-usa";
 
 		public List<Candidate> Result { get; private set; }
 
@@ -61,7 +58,7 @@ public enum Format
 		public string MatchStrategy { get; set; }
 
 		[DataMember(Name = "format")]
-		public Format OutputFormat { get; set; }
+		public string OutputFormat { get; set; }
 
 		public int MaxCandidates
 		{
@@ -96,18 +93,5 @@ public void AddToResult(Candidate newCandidate)
 		{
 			this.Result.Add(newCandidate);
 		}
-
-		public string GetFormatString()
-		{
-			switch (this.OutputFormat)
-			{
-				case Format.Default:
-					return "default";
-				case Format.ProjectUsa:
-					return "project-usa";
-				default:
-					return "";
-			}
-		}
 	}
 }
diff --git a/src/tests/USStreetApi/ClientTests.cs b/src/tests/USStreetApi/ClientTests.cs
@@ -67,7 +67,7 @@ public void TestSendingSingleFullyPopulatedLookupWithFormatOutput()
 				ZipCode = "7",
 				Lastline = "8",
 				MatchStrategy = "enhanced",
-				OutputFormat = Lookup.Format.ProjectUsa
+				OutputFormat = Lookup.PROJECT_USA_FORMAT
 			};
 
 			client.Send(lookup);