Fun3d 14.0 Interface #279
Merged
Fun3d 14.0 Interface #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sean-engelstad
commented
Feb 14, 2024
sean-engelstad
commented
- A separate FUN3D 14 interface is created for FUN3D version 14.0.2 the time being to allow backwards compatibility (we will clean this up later probably).
- One of the main motivators for using FUN3D 14.0 is the new HANIM forward solver which we've shown converges the forward coupled flow problem 5x times faster in some cases.
- Fortran contiguous arrays were changed to C contiguous arrays
- added last step attributes for FUN3D forward + adjoint as the HANIM solver in FUN3D 14.0 will sometimes exit early and reading the RMS residuals will fail
- Separate mode for complex vs real as FUN3D 14.0 does not accept complex arrays when in real mode (previously it was casting them down to doubles)
bburke38
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.