Update v4 changelog #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mike Sheppard <[email protected]>
* Add support for hashed assets
1. This hopefully simplifies our checks a bit as we're already gathering most of this info within `svg_collector()`, so we shouldn't need to check again.
2. By saving the full path in `svg_collector()` we can provide support for hashed assets eg. `arrow-left.524a72.svg`
```php
"arrow left" => [
"name" => "arrow left"
"filename" => "arrow-left.524a72"
"icon" => "arrow-left.524a72.svg"
"url" => "/dist/editor/images/icons/admin-picker/arrow-left.524a72.svg"
]
```
3. Also, might be better to save an ID (`sanitize_key($name)`) of the icon to the ACF field instead of the name?
* Fix filters
* Use sanitized key for ACF field val instead 'name'
* Bring back normalized title in filter
* Fix icon array check
* Support legacy field values
* README tweaks - add filters + release links
* Fix phpcs config, igmore `*/wp-content/*`
* Add missing void return type
* Move js, css & extract views into resources
* Add composer aliases/nicknames
* Fix silly typos
* Add Test: check sanitised and legacy (unsanitised) acf values
* Add missing return types + simplify acf field view phpstan issues * Fix logic typo + encode plus symbol * Update versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary