Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sources and javadoc jars to publication, Fix staging directory #584

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

haydenbaker
Copy link
Contributor

@haydenbaker haydenbaker commented Feb 6, 2025

Description of changes:

  • Staging directory was incorrectly set
    • ex: the directories getting created were named /property(org.gradle.api.file.Directory, fixed(class org.gradle.api.internal.file.DefaultFilePropertyFactory$FixedDirectory, / under each module's build dir
      • specifically, DirectoryProperty being interpolated, which doesn't have a toString method
    • This may have still worked because the dirs still get created and populated, but it's still wrong
    • The correct path is build/staging, and all publications should be put there
  • Javadoc and Sources jars were not being created in the publications
  • framework-errors package had some ordering and duplication issues, workarounds added

Testing:

  • gradle clean build publish
  • set up dummy signing secrets with JReleaser, run gradle jreleaserRelease
  • inspect trace log, should fail (no nexus credentials)
    • verify POM checker passes
    • verify artifacts are signed

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@haydenbaker haydenbaker requested a review from hpmellema February 6, 2025 04:03
@haydenbaker haydenbaker force-pushed the haydenbaker/fix-publications-and-staging branch from c822275 to 5820c16 Compare February 6, 2025 04:13
@mtdowling mtdowling merged commit c3d7995 into main Feb 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants