-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Github Actions CI #13
Conversation
5dd5bc8
to
10ba521
Compare
|
||
jobs: | ||
stable: | ||
runs-on: ubuntu-latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we really should have macOs and Windows here too :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree :) Also BSD if it's available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stjepang BSD is not available unless you want to plug a custom runner, and if the actions runner works on BSD. But macOS is a bsd variant so that should at least cover most of failures.
Can we rebase this on master branch to give CI a fresh run? |
17041c7
to
5d42395
Compare
Tried to add macOS and Windows but it might fail because the actions.rs Github Actions framework may not support these. |
@dignifiedquire Yes, it certainly does, I just tried to make use of: https://github.com/actions-rs |
@dignifiedquire Looks like it works on macos and windows too, now it's just an issue with wepoll-sys not building somehow |
@stjepang Already opened an issue for this here: https://gitlab.com/yorickpeterse/wepoll-sys/-/issues/1 |
Also we should watch this closely: actions-rs/meta#21 Caching is important, wasting compute resources is not fun. And well.. we can't say CI/CD as a concept isnt already a big source of energy waste.. |
And sorry for the repeated posts, but I have another thing to say: It seems that build failure on windows canceled all the other build, is that OK? |
it woul be nice if the oses would run by themselves, especially as windows is a known failure atm |
Also: servo/rust-cssparser#273 - for code coverage |
@Leo-LB To install LLVM on Windows: actions/runner-images#104 (comment) |
@stjepang Cool! I added that. |
Okay the remaining issue is easy to fix and unrelated - I'll do that separately from this PR since I'm updating lib.rs right now :) Merging this, thank you for the PR! I'm very happy that we now have CI for the three major operating systems! <3 |
@stjepang I did not realize the repo was private here: servo/rust-cssparser#273 - stupid me. |
@Leo-LB It seems only code coverage is failing now but I don't understand why: https://github.com/stjepang/smol/runs/618593373 Do you have any ideas? |
@stjepang yes look at the issue I opened against cssparser just above. |
No description provided.