Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support req.resolve(key) #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Hypnosphi
Copy link

@techieshark
Copy link

I'm wondering what the status of this PR is?

It looks like it is a blocker for Storybook - storybookjs/storybook#7697 (comment)

There's a workaround in Storybook - updating jest.config.js like so -

transform: {
  // should be above any other js transform like babel-jest
  '^.+\\.stories\\.js$': '<rootDir>/path/to/injectFileName',
}

but it seems that workaround doesn't work for Create React App users who can't edit their jest config:

storybookjs/storybook#9946

(So I'm wondering if merging this would help with the above CRA issue.)

@luke-j
Copy link

luke-j commented May 1, 2020

Is this PR able to be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants