Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to opt-in to Wayland support #254

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

AKoskovich
Copy link
Contributor

No description provided.

@AKoskovich AKoskovich changed the title Allow users to opt-in to Wayland support with ELECTRON_OZONE_PLATFOR_HINT Allow users to opt-in to Wayland support Jan 22, 2025
@jnsgruk
Copy link
Member

jnsgruk commented Jan 22, 2025

Thank you, could we also add the wayland plug to the list of plugs for the discord app? (see https://snapcraft.io/docs/wayland-interface)

@jnsgruk jnsgruk requested a review from kenvandine January 22, 2025 09:14
@AKoskovich
Copy link
Contributor Author

Thank you, could we also add the wayland plug to the list of plugs for the discord app? (see https://snapcraft.io/docs/wayland-interface)

It's already present by default no? Unless you just want it explicitly mentioned as a plug in the yml

@kenvandine
Copy link
Contributor

The wayland plug is provided by the gnome extension, no need to specify it

@jnsgruk jnsgruk merged commit a3d89cf into snapcrafters:candidate Jan 22, 2025
1 check passed
@kenvandine
Copy link
Contributor

How would a user opt-in? Without the WAYLAND_OPTS being set, will the platform pick it up automatically?

@AKoskovich
Copy link
Contributor Author

AKoskovich commented Jan 22, 2025

How would a user opt-in? Without the WAYLAND_OPTS being set, will the platform pick it up automatically?

By setting the environment variable ELECTRON_OZONE_PLATFORM_HINT to auto (defaults to Wayland if possible, falls back to X11 otherwise).

e.g.

~/.config/environment.d/electron.conf 
ELECTRON_OZONE_PLATFORM_HINT=auto

@kenvandine
Copy link
Contributor

Wouldn't it be easier to allow users to opt-out? Or is the wayland support not good enough yet? If we revert that launcher script change, all you need to do is disconnect the wayland plug to disable wayland support.

@jnsgruk
Copy link
Member

jnsgruk commented Jan 22, 2025

Wayland support has been pretty ropey for discord, I'd want to see the results of more testing before making it opt-out I think

@AKoskovich
Copy link
Contributor Author

Wouldn't it be easier to allow users to opt-out? Or is the wayland support not good enough yet? If we revert that launcher script change, all you need to do is disconnect the wayland plug to disable wayland support.

Wayland support is definitely not good enough yet, users can't even resize windows on GNOME currently.
electron/electron#44543

However they did fix screen sharing recently so there's that. I would say it's all gtg for KDE users though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants