Do not change desktop file name

[AKoskovich]

By default snap creates desktop entries in the format of '{SNAP_NAME}_{APP_NAME}.desktop' which breaks the way KDE associates windows with their desktop file.

This commit fixes the app icon in KDE's provided window decorations.

[AKoskovich]

The issue only shows up if you're running the app in Wayland, I believe in X11 the app is manually changing the icon.

[AKoskovich]

Errr anyone more familiar with snaps know why CI fails?

Additional properties are not allowed, not sure what it means by that, was able to build with snapcraft locally.

[jnsgruk]

Are the snapcraft versions different? :)

[lengau]

Thanks for the PR!

It's not snapcraft that's failing here, it's review-tools. Specifically, I think the reason for it is this bug: https://bugs.launchpad.net/review-tools/+bug/2081240
You should be able to reproduce this locally by installing the review-tools snap and running snap-review on your generated snap file.

Based on the docs, it looks like this change will also require updating the assumes line to assume snapd2.66.

[AKoskovich]

It's not snapcraft that's failing here, it's review-tools. Specifically, I think the reason for it is this bug: https://bugs.launchpad.net/review-tools/+bug/2081240 You should be able to reproduce this locally by installing the review-tools snap and running snap-review on your generated snap file.

Yeah fails here locally. Would this resolve it? https://git.launchpad.net/~alexmurray/review-tools/commit/?id=6108e3aae4190ad1900ffec5bedf17dacaf37ee1

Based on the docs, it looks like this change will also require updating the assumes line to assume snapd2.66.

Done

[jnsgruk]

@AKoskovich not sure I'm comfortable merging this with the CI red; did you make any progress on understanding how we can fix this?

[AKoskovich]

@AKoskovich not sure I'm comfortable merging this with the CI red; did you make any progress on understanding how we can fix this?

Can't be fixed until review-tools is updated from what I can tell. Seems like Alex Murray has a change to fix it but don't know when it'll make it to the main branch.

[jnsgruk]

@AKoskovich not sure I'm comfortable merging this with the CI red; did you make any progress on understanding how we can fix this?

Can't be fixed until review-tools is updated from what I can tell. Seems like Alex Murray has a change to fix it but don't know when it'll make it to the main branch.

Lemme look into it - thanks!

[jnsgruk]

This is now "fixed", in that the patch has been merged into review-tools, and has landed on edge, but not yet on stable - so I'm gonna delay merging until that's landed on stable :)

Revision 4245 of review-tools contains the fix.