Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: extract cache logic from getScores #941

Open
wants to merge 5 commits into
base: extract-cache
Choose a base branch
from

chore: instrument the cache layer (#942)

b78d40d
Select commit
Loading
Failed to load commit list.
Open

refactor: extract cache logic from getScores #941

chore: instrument the cache layer (#942)
b78d40d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 6, 2023 in 0s

72.27% (-2.73%) compared to 7921024

View this Pull Request on Codecov

72.27% (-2.73%) compared to 7921024

Details

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (7921024) 75.00% compared to head (b78d40d) 72.27%.
Report is 3 commits behind head on extract-cache.

Additional details and impacted files
@@                Coverage Diff                @@
##           extract-cache     #941      +/-   ##
=================================================
- Coverage          75.00%   72.27%   -2.73%     
=================================================
  Files                 12       12              
  Lines                664      689      +25     
  Branches             111      108       -3     
=================================================
  Hits                 498      498              
- Misses               163      188      +25     
  Partials               3        3              
Files Coverage Δ
src/metrics.ts 63.15% <100.00%> (+6.90%) ⬆️
src/scores.ts 84.09% <58.82%> (-15.91%) ⬇️
src/helpers/cache.ts 73.13% <33.33%> (-26.87%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.