Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Increase strategies limit #998

Merged
merged 7 commits into from
Dec 27, 2023
Merged

fix: Increase strategies limit #998

merged 7 commits into from
Dec 27, 2023

Conversation

ChaituVR
Copy link
Member

@ChaituVR ChaituVR commented Dec 23, 2023 •
edited
Loading

  • This will increase the strategies limit from 8 to 10
  • Also adds a check for strategies length on get_vp

Refer https://discord.com/channels/955773041898573854/1187284357799481484/1188191395261972640

@codecov Codecov
Copy link

codecov bot commented Dec 23, 2023 •
edited
Loading

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Files Patch % Lines
src/aws.ts 33.33% 2 Missing ⚠️
src/helpers/keycard.ts 0.00% 2 Missing ⚠️
src/rpc.ts 77.77% 2 Missing ⚠️
Additional details and impacted files

📢 Thoughts on this report? Let us know!

wa0x6e
wa0x6e reviewed Dec 24, 2023
View reviewed changes
src/rpc.ts Outdated Show resolved Hide resolved
@ChaituVR ChaituVR requested a review from wa0x6e December 25, 2023 07:57
wa0x6e
wa0x6e requested changes Dec 27, 2023
View reviewed changes
src/utils.test.ts Outdated Show resolved Hide resolved
wa0x6e
wa0x6e approved these changes Dec 27, 2023
View reviewed changes
Copy link
Contributor

@wa0x6e wa0x6e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@ChaituVR ChaituVR merged commit 2d478dc into master Dec 27, 2023
4 checks passed
@ChaituVR ChaituVR deleted the increase-strategies-limit branch December 27, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wa0x6e wa0x6e wa0x6e approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChaituVR @wa0x6e