fix: get strategies data from DB directly
#718
Conversation
| const results = new Map( | ||
| ( | ||
| await db.queryAsync(` | ||
| SELECT |
There was a problem hiding this comment.
This can be an heavy request isn't? How long does it take to resolve? How often is it called?
There was a problem hiding this comment.
~40ms to resolve, on my dataset of 13k spaces.
It's still not 100% live query, as it's only run along the fetch strategies query from score url, so once every 1min
There was a problem hiding this comment.
Do you want more refactoring, and use 100% live counters (and not cached for 1min) ?
This will bring more consistency, as no other counters are cached and lagging behind.
By enforcing only known strategies when submitting via sequencer, we could also get rid of the condition, checking if the strategy is a valid one from score-api, and have true live data from the strategies operation. (can also get rid of the /helpers/startegies.ts file)
There was a problem hiding this comment.
I prefer not using such query as live query, also not sure how you would get ride of strategies helpers, this is loading strategies metadata that are not available from the hub
There was a problem hiding this comment.
true, forgot about the other strategies data. We get less than 1 request/min on the hub for the strategies object, should have very minimal impact on performance
There was a problem hiding this comment.
Takes around 2.8s on prod, will increase when we get more space 🤔
|
Return to WIP, will add some cache and update strategy |
🧿 Current issues / What's wrong ?
The
strategiesquery on the hub is using data from space's cache.This create refresh lag, and dependency on the
spacecache object.💊 Fixes / Solution
Use a SQL query to get strategies data from the database
🚧 Changes
strategiesObjglobal object. The data can already be queried using a simplefindon thestrategiesglobal variable.🛠️ Tests