fix: use AND operator when searching for multiple labels
#957
Conversation
wa0x6e
changed the title
AND operators when searching for multiple labels
wa0x6e
changed the title
AND operators when searching for multiple labelsAND operator when searching for multiple labels
| @@ -73,7 +73,7 @@ export default async function (parent, args) { | |||
| } | |||
|
|
|||
| if (where?.labels_in?.length) { | |||
There was a problem hiding this comment.
Maybe we should rename to labels_contains like in https://github.com/snapshot-labs/workflow/issues/254#issuecomment-2500056076 ?
There was a problem hiding this comment.
May I ask why?
labels_in is consistent with all the other *_in filters, using AND operator
There was a problem hiding this comment.
Just to keep it the same as SX, else I don't have any problems with _in
Refer https://github.com/snapshot-labs/workflow/issues/254#issuecomment-2500056076
There was a problem hiding this comment.
But i already approved PR, in case we want to proceed 😅 no problem in using _in
There was a problem hiding this comment.
It's fine to keep _in filter, we dont want to have both _in and _contains and we don't want to change things in snapshot.org or the new UI. We will merge all to the same syntax once we have a single API.
Toward https://github.com/snapshot-labs/workflow/issues/254
This PR will change how proposal's labels are searched for.
Currently,
labels_inoperates with theORoperator, and when searching for[1, 2], will return proposals with either1or2.This PR will change the operator to
AND(to be consistent with all other existing_infilters), so that when searching for[1, 2], will return results for proposals that have both1and2