Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hopr-stake-and-balance-qv] Improve hopr-stake-and-balance-qv strategy #1452

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

QYuQianchen
Copy link
Contributor

According to feedback from community members, here are some improvements and bug fixes to the voting strategy.

Changes proposed in this pull request:

  • Improve error catching in the cross-chain block-number conversion so that the fallback block number can be used whe the subgraph is down.
  • Specify type definition for number types.
  • Make subgraph util functions use an explicit block number.
  • Update the "safe stake query id" and "latest version string" in the example.json file

@ChaituVR ChaituVR changed the title Improve hopr-stake-and-balance-qv strategy [hopr-stake-and-balance-qv] Improve hopr-stake-and-balance-qv strategy Apr 10, 2024
Copy link
Member

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see an active proposal at https://snapshot.org/#/vote.hopr.eth/proposal/0xc7c172d20247df0c255a05f0773e321ef80c98af4f7a7bacec4e9a3a2435ab87 which is using this strategy. i would suggest to merge this after the end of this proposal

@QYuQianchen
Copy link
Contributor Author

Thanks @ChaituVR for the review. Sounds good 👍. A related question: if the strategy implementation gets updated during an ongoing voting, will the scores being calculated according to the newer version or will the is the strategy anchored at a specific IPFS version/commit so it's calculated with an older version?

@ChaituVR
Copy link
Member

ill the scores being calculated according to the newer version or will the is the strategy anchored at a

Scores will be calculated with newer version but we have many cache systems, so if someone already tried to vote, they may see older voting power. so we always check if there is a active proposal in case someone want to update existing strategy, or other way is to create a new strategy and use it on new proposals ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants