Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Build error with node 16 #4367

Closed
wants to merge 1 commit into from
Closed

fix: Build error with node 16 #4367

wants to merge 1 commit into from

Conversation

samuveth
Copy link
Contributor

@samuveth samuveth commented Nov 17, 2023

Summary

Node 16 is causing an error:

error [email protected]: The engine "node" is incompatible with this module. Expected version ">=18.12.0". Got "16.20.2"
error Found incompatible module.

Link here https://github.com/snapshot-labs/snapshot/actions/runs/6901813993/job/18777319524?pr=4368

Copy link

vercel bot commented Nov 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
snapshot ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 17, 2023 8:49am

@wa0x6e
Copy link
Collaborator

wa0x6e commented Nov 17, 2023

Fleek is still on node:16, are we sure the repo can run on node18 ?

@wa0x6e
Copy link
Collaborator

wa0x6e commented Nov 17, 2023

Or you just running the CI on node 18, and keep the code on 16 ?

@samuveth
Copy link
Contributor Author

Good point. I'm not sure why I'm getting this error here #4368

lint-staged is no longer installed. Any idea?

@wa0x6e
Copy link
Collaborator

wa0x6e commented Nov 17, 2023

I don't get any errors when running the same scripts locally, on node 16

@samuveth
Copy link
Contributor Author

Ah weird it's showing a different error now 🤔

@samuveth
Copy link
Contributor Author

I don't get any errors when running the same scripts locally, on node 16

With this PR? #4368

@wa0x6e
Copy link
Collaborator

wa0x6e commented Nov 17, 2023

Error coming from vite 5, which require node 18 minimum now

@samuveth samuveth closed this Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants