Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix invalid status when saving delegate statement #4878

Merged
merged 1 commit into from
Sep 18, 2024
Merged

fix: fix invalid status when saving delegate statement #4878

merged 1 commit into from
Sep 18, 2024

Conversation

wa0x6e
Copy link
Collaborator

@wa0x6e wa0x6e commented Sep 18, 2024 •
edited
Loading

Summary

Saving a new delegate statement is not doing anything, clicking on the "Save changes" button in the edit delegate statement form is not doing anything (no error shown)

This PR fix this issuem by setting the hidden field correctly

How to test

  1. Go to a http://localhost:8080/#/cowtesting.eth/delegate/YOUR-ADDRESS or any other space with delegation dashboard where you don't have a statement yet
  2. Edit and save the statement
  3. It should save the statement

@wa0x6e wa0x6e requested a review from ChaituVR September 18, 2024 04:06
ChaituVR
ChaituVR approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@wa0x6e wa0x6e merged commit da349c4 into master Sep 18, 2024
5 checks passed
@wa0x6e wa0x6e deleted the fix-unable-to-save-delegate-statement branch September 18, 2024 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChaituVR ChaituVR ChaituVR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wa0x6e @ChaituVR