Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Editor title should reflect update status #802

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Sep 23, 2024

Summary

Toward #801

This PR shows the correct title in TopNav when editing a proposal

How to test

  1. Go to a proposal edition page
  2. The tiltle in topnav should now says "Update proposal"

Copy link

changeset-bot bot commented Sep 23, 2024

⚠️ No Changeset found

Latest commit: 0bff5ca

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@wa0x6e wa0x6e requested a review from ChaituVR September 23, 2024 09:51
@wa0x6e wa0x6e marked this pull request as ready for review September 23, 2024 09:51
@wa0x6e wa0x6e changed the title fix: title should reflect update status fix: Editor title should reflect update status Sep 23, 2024
@ChaituVR
Copy link
Member

How to go to a proposal edition page? is there an example URL?

@wa0x6e wa0x6e closed this Sep 23, 2024
@wa0x6e wa0x6e reopened this Sep 23, 2024
@wa0x6e
Copy link
Contributor Author

wa0x6e commented Sep 23, 2024

How to go to a proposal edition page? is there an example URL?

Create a pending onchain proposal, then edit it in the dropdown menu in the proposal overview page (same menu as delete)

@ChaituVR
Copy link
Member

Create a pending onchain proposal, then edit it in the dropdown menu in the proposal overview page (same menu as delete)

Ah, I was checking on offchain pending proposals. there is no option there weirdly 🤔

@wa0x6e
Copy link
Contributor Author

wa0x6e commented Sep 23, 2024

Create a pending onchain proposal, then edit it in the dropdown menu in the proposal overview page (same menu as delete)

Ah, I was checking on offchain pending proposals. there is no option there weirdly 🤔

Yes, not supported for offchain

Copy link
Member

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck

@wa0x6e wa0x6e merged commit 408d7cf into master Sep 24, 2024
3 checks passed
@wa0x6e wa0x6e deleted the fix-wrong-title-in-editor branch September 24, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants