feat: struct packing #503
Merged
feat: struct packing #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Orland0x
reviewed
Aug 18, 2023
| timestamps_and_finalization_status: u128, // In order: start, min, max, finalization_status | ||
| execution_payload_hash: felt252, | ||
| execution_strategy: ContractAddress, | ||
| author: UserAddress, |
There was a problem hiding this comment.
Annoying that the UserAddress adds storage overhead. one solution could be to store a felt252 hash of it that we then compute when neeeded. probably unnecessary complexity though
There was a problem hiding this comment.
Technically, most of the time the UserAddress will be ethereum / starknet and will felt in a single felt so the storage will not move (will stay 0) so i don't think it will cost that much?
Orland0x
reviewed
Aug 18, 2023
| active_voting_strategies: u256, | ||
| } | ||
|
|
||
| impl ProposalStorePacking of StorePacking<Proposal, PackedProposal> { |
There was a problem hiding this comment.
really like cairo's approach to packing. super clean and efficient
There was a problem hiding this comment.
one thing is make sure you #[derive(starknet::Store)] and not #[derive(Store)]. Found out the hard way...
…eat_struct_packing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement struct packing (for Proposal, as the Storage struct will not be modified as much) using the
StorePackingtraitCloses #483