feat: l1 execution #516
Merged
feat: l1 execution #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
August 22, 2023 13:30
Sekhmet
reviewed
Aug 30, 2023
added 7 commits
August 31, 2023 13:25
pscott
reviewed
Sep 1, 2023
Comment on lines
+24
to
+26
| // We cannot have early proposal execution with this strategy because we determine the proposal status | ||
| // on L1 in a separate tx and therefore cannot ensure that the proposal is not still in the voting period | ||
| // when it is executed. |
There was a problem hiding this comment.
In the future, I wonder if we'd be able to prove the output of getProposalStatus on a contract C with storage S on chain X, with a clever use of storage proofs :D
Orland0x
force-pushed
the
fix_l1_exec
branch
from
2becc11
to
d1a3b3e
Compare
pscott
approved these changes
Sep 4, 2023
| STARKNET_SIERRA_COMPILE_PATH: ./cairo/bin/starknet-sierra-compile | ||
| OBJC_DISABLE_INITIALIZE_FORK_SAFETY: YES | ||
| ADDRESS: "0x347be35996a21f6bf0623e75dbce52baba918ad5ae8d83b6f416045ab22961a" | ||
| PK: "0xbdd640fb06671ad11c80317fa3b1799d" |
There was a problem hiding this comment.
The address above it
There was a problem hiding this comment.
haha yeah I figured but I just wanted to make sure this was indeed a random pk and not one of yours :)
alright addressed everything. thanks for detailed review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.