New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add proposalId to proposalCreated event #619

Merged

pscott merged 1 commit into develop from refactor_add_proposalid_to_proposalCreated_event

Jun 10, 2024

Contributor

pscott commented Jun 3, 2024 •

edited

Loading

Adds the proposalId to ProposalCreated event
Removes the salt used in MetaTransaction
Had to modify the execute signature function to take a Votes struct because compilation would fail due to the EVM's restrictions of stack. Basically, votesFor / votesAbstain / votesAgainst have all been packed in a struct now

Closes #616


          refactor: add proposalId to proposalCreated event; remove Salt in Met…

c4781c8

…aTransaction

pscott force-pushed the refactor_add_proposalid_to_proposalCreated_event branch from 9e8d309 to c4781c8 Compare

June 6, 2024 16:26

pscott requested a review from Sekhmet

June 7, 2024 08:48

Sekhmet approved these changes

View reviewed changes

pscott merged commit df4b6fd into develop

2 checks passed

pscott deleted the refactor_add_proposalid_to_proposalCreated_event branch

June 10, 2024 13:36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet