Make url as feature and bump version

[Its-Just-Nans]

Hello,

This PR fixes:

• Remove or make even more optional the url crate in the next version.  #412
• Bump version #409

[daniel-abramov]

Looks good. One question though: why is the newly introduced tests/url_feature.rs is a copy-paste of the existing test (with the only single exception of using Url)? - I think this might be a bit confusing.

[Its-Just-Nans]

Yes.
I changed the test. Is that better ?

Thanks

[daniel-abramov]

Looks good!

Just to clarify one thing: if I got your intentions right, you want us to publish a new version after merging this PR, right? (otherwise CHANGELOG should contain Unreleased instead of 0.22.0 and also the update in the Cargo.toml would also not be necessary).

AFAIR originally we wanted to first wait for #363 first and then release a version. But if a builder pattern is useful on its own, we could make a release before #363 I think.

[Its-Just-Nans]

Looks good!

Just to clarify one thing: if I got your intentions right, you want us to publish a new version after merging this PR, right? (otherwise CHANGELOG should contain Unreleased instead of 0.22.0 and also the update in the Cargo.toml would also not be necessary).

AFAIR originally we wanted to first wait for #363 first and then release a version. But if a builder pattern is useful on its own, we could make a release before #363 I think.

Yes, make a release version is my goal. With a new version I could (update and) merge rerun-io/ewebsock#27 crate which is using tungstenite

For #363 I think @conorbros is a little busy at the moment because I sent him a PR (shotover#1) but he didn't accept it for now

A solution could be to merge https://github.com/Its-Just-Nans/tungstenite-rs/tree/master directly into tungstenite (without passing by the fork of @conorbros). But that would make @conorbros invalid his PR. I don't know if it's a good and acceptable way of doing it

Thanks for the suggested modifications!

[Its-Just-Nans]

I think #363 may be mergeable now (thank you @conorbros) !

So maybe we can merge #363 then this one ?

[daniel-abramov]

That makes sense. I think we could merge #363; it just requires minor updates to pass the CI.

[Its-Just-Nans]

@daniel-abramov I think this PR is blocked by invisible/old "requested changes"